underhill_mem: Wire up TLB access for flushing and locking #841
+277
−115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sluck-msft
reviewed
Feb 13, 2025
smalis-msft
force-pushed
the
uh-mem-tlb
branch
from
a3a483c to
d91d4a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a new trait, TlbFlushLockAccess, that is used to allow memory protections management code to access the VP's TLB flush and lock machinery. It then adds a new parameter of this type to certain methods on ProtectIsolatedMemory, and adds calls to it where appropriate.
This also adds a small hack to avoid an ongoing layering discussion. We're unsure of the right approach to fix it, but the rest of the code should be fine as-is.
Open question: Do we have the right calls everywhere needed? I tried to match up our code with the legacy HCL's, but our design and flow are very different, so I'm not 100% confident I got them all correct.
Part 1 of #849