Fix lints for Rust 1.84 #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarks
reviewed
Jan 9, 2025
jstarks
reviewed
Jan 9, 2025
jstarks
reviewed
Jan 9, 2025
jstarks
reviewed
Jan 9, 2025
smalis-msft
force-pushed
the
rust-184-lints
branch
from
c859a4c to
96cd6fe
Compare
smalis-msft
force-pushed
the
rust-184-lints
branch
from
96cd6fe to
1ad87af
Compare
daprilik
approved these changes
Jan 9, 2025
benhillis
pushed a commit
to benhillis/openvmm
that referenced
this pull request
Jan 15, 2025
The biggest two here are changing `map_or(false,` to `is_some_and` or `is_ok_and`, and the changing of rules around how refs in patterns work (which is technically a future-compat lint, but its easy enough to take now), but there's also some elided lifetimes and other general cleanups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The biggest two here are changing
map_or(false,tois_some_andoris_ok_and, and the changing of rules around how refs in patterns work (which is technically a future-compat lint, but its easy enough to take now), but there's also some elided lifetimes and other general cleanups.