Update version number #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binyang2014
requested review from
Copilot and
chhwang
and removed request for
Copilot
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
chhwang
requested changes
Jan 2, 2025
There was a problem hiding this comment.
You need to update versions in the code as well: https://github.com/microsoft/mscclpp/blob/main/include/mscclpp/core.hpp#L7-L9
We may need an automation to prevent future mistakes.
Add VERSION file, we only need to modify this file to update the version, github action will do following things |
Binyang2014
added a commit
that referenced
this pull request
Jan 3, 2025
Co-authored-by: github-actions <[email protected]>
Binyang2014
added a commit
that referenced
this pull request
Jan 3, 2025
Co-authored-by: github-actions <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.