Flushing Proxy Channels at CPU side upon reaching the Inflight Request Limit #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binyang2014
reviewed
Dec 17, 2024
yzygitzh
reviewed
Dec 20, 2024
chhwang
requested changes
Jan 3, 2025
include/mscclpp/core.hpp
Outdated
| /// Get the max inflight requests. | ||
| /// | ||
| /// @return max inflight requests. | ||
| int maxInflightRequests(); |
There was a problem hiding this comment.
The name is not very accurate
include/mscclpp/core.hpp
Outdated
|
|
||
| /// Constructor that takes a transport and sets the other fields to their default values. | ||
| /// | ||
| /// @param transport The transport to use. | ||
| EndpointConfig(Transport transport) : transport(transport) {} | ||
| EndpointConfig(Transport transport = Transport::Unknown, int maxInflightRequests = -1) |
There was a problem hiding this comment.
Please add all other members as a constructor variable as well
src/connection.cc
Outdated
| // CudaIpcConnection | ||
|
|
||
| CudaIpcConnection::CudaIpcConnection(Endpoint localEndpoint, Endpoint remoteEndpoint, cudaStream_t stream) | ||
| : stream_(stream) { | ||
| : Connection(localEndpoint.maxInflightRequests() != -1 ? localEndpoint.maxInflightRequests() : INT_MAX), |
There was a problem hiding this comment.
Perhaps we can just use -1 instead of INT_MAX, regarding -1 as infinite
There was a problem hiding this comment.
Do you want the same for EthernerConnection?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.