Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add headers support #65

Merged
merged 24 commits into from
Aug 31, 2023
Merged

Add headers support #65

merged 24 commits into from
Aug 31, 2023

Conversation

calebkiage
Copy link
Contributor

@calebkiage calebkiage commented Aug 21, 2023 •
edited
Loading

Designed headers option for kiota generated clients.

The headers option will be available to clients that want to use it if they call:

commandBuilder.RegisterHeadersOption(headersStoreGetter)

or

commandBuilder.RegisterHeadersOption(headersStoreGetter, "--option-name")

or

commandBuilder.RegisterHeadersOption(headersStoreGetter, "--option-name", "custom option description")

The headersStoreGetter parameter is a function that when called, returns an instance of IHeadersStore.

This is an optional feature and clients that don't want it can simply ignore the feature.

Closes #62

@calebkiage calebkiage changed the title Add headers store interface with default in-memory store. Add headers support Aug 21, 2023
@calebkiage calebkiage mentioned this pull request Aug 21, 2023
Closed
@calebkiage calebkiage marked this pull request as ready for review August 21, 2023 16:26
baywet
baywet approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the making the changes and the long haul open discussions.

peombwa
peombwa approved these changes Aug 31, 2023
View reviewed changes
Copy link

@peombwa peombwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

90.7% 90.7% Coverage
0.0% 0.0% Duplication

@calebkiage calebkiage merged commit c56d4c1 into main Aug 31, 2023
@calebkiage calebkiage deleted the feat/headers-support branch August 31, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman left review comments

@ddyett ddyett ddyett left review comments

@peombwa peombwa peombwa approved these changes

@baywet baywet baywet approved these changes

@zengin zengin Awaiting requested review from zengin

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@Ndiritu Ndiritu Awaiting requested review from Ndiritu

@rkodev rkodev Awaiting requested review from rkodev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Design generic header options feature
5 participants
@calebkiage @andrueastman @peombwa @baywet @ddyett