Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use run.bat instead of "go tool dist test" on Windows #1564

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

qmuntal
Copy link
Member

@qmuntal qmuntal commented Feb 17, 2025

Go 1.25 dev branch supports passing arguments to the underlying command. See https://go-review.googlesource.com/c/go/+/647116.

We can remove the hack on our end.

Closes #109.

@qmuntal qmuntal requested a review from a team as a code owner February 17, 2025 10:39
@qmuntal qmuntal merged commit 8319230 into microsoft/main Feb 17, 2025
35 checks passed
@qmuntal qmuntal deleted the dev/qmuntal/godistwin branch February 17, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"src/run.bat" doesn't pass args through to "dist test" like "src/run.bash" does, making "-json" ineffective
2 participants