Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ADF errors in Hubs 0.2 #574

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Fix ADF errors in Hubs 0.2 #574

merged 3 commits into from
Feb 5, 2024

Conversation

flanakin
Copy link
Collaborator

@flanakin flanakin commented Feb 3, 2024

🛠️ Description

  1. Resolves ADF errors by creating variables to work around the syntax parsing bug
  2. Fixed a typo in the trigger starting script
  3. Updated deploy to Azure buttons to link to FTK-hosted template files

📋 Checklist

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests
  • 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Yes (required for dev PRs)
  • ➡️ Will cover in a future PR (feature branch PRs only)
  • ❎ Not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will cover in a future PR (feature branch PRs only)
  • ❎ Not needed (small/internal change)

@flanakin flanakin merged commit 17a55fd into dev Feb 5, 2024
1 check passed
@flanakin flanakin deleted the flanakin/dev/hubs-pipelinefixes branch February 5, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Review 👀 PR that is ready to be reviewed Tool: FinOps hubs Data pipeline solution
Projects
None yet
1 participant