Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cost optimization workbook dec release #514

Merged

Conversation

sebassem
Copy link
Contributor

@sebassem sebassem commented Jan 1, 2024

🛠️ Description

  • Added new queries for Azure Firewall
  • Added new queries for Azure Backup
  • Added a query to check for Advisor recommendations for Log Analytics
  • Improved AHB queries for SQL DBs
  • Improved LB query to ignore Basic SKU
  • Improved Idle disks query to ignore ASR replica disks.

📷 Screenshots

📋 Checklist

🔬 How did you test this change?

  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Yes (required for dev PRs)
  • ➡️ Will cover in a future PR (feature branch PRs only)
  • ❎ Not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will cover in a future PR (feature branch PRs only)
  • ❎ Not needed (small/internal change)

Copy link
Collaborator

@flanakin flanakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. My only request is to also update the changelog.

@arthurclares arthurclares merged commit d342b83 into microsoft:features/workbookv2 Jan 9, 2024
2 checks passed
@sebassem
Copy link
Contributor Author

sebassem commented Jan 9, 2024

Looks good. My only request is to also update the changelog.

Sure thing, just to be sure this link is what we should update ? and on which branch ? dev ?

@sebassem sebassem deleted the workbook_dec_release branch February 1, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Review 👀 PR that is ready to be reviewed Tool: Workbooks Azure Monitor workbooks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Workbook] Include RSV queries to check the vault's replication settings
3 participants