Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -AsDotNetVersion option to the Get-Version script #498

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

flanakin
Copy link
Collaborator

πŸ› οΈ Description

Add Get-Version -AsDotNetVersion to return a version number that does not use a prerelease name to avoid errors with .NET based build number systems.

πŸ“‹ Checklist

πŸ”¬ How did you test this change?

  • 🀞 PS -WhatIf / az validate
  • πŸ‘ Manually deployed + verified
  • πŸ’ͺ Unit tests

πŸ™‹β€β™€οΈ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🀏 The change is less than 20 lines of code.

πŸ“‘ Did you update docs/changelog.md?

  • βœ… Yes (required for dev PRs)
  • ➑️ Will cover in a future PR (feature branch PRs only)
  • ❎ Not needed (small/internal change)

πŸ“– Did you update documentation?

  • βœ… Public docs in docs (required for dev)
  • βœ… Internal dev docs in src (required for dev)
  • ➑️ Will cover in a future PR (feature branch PRs only)
  • ❎ Not needed (small/internal change)

@flanakin flanakin requested a review from a team December 17, 2023 10:33
@microsoft-github-policy-service microsoft-github-policy-service bot added the Skill: DevOps GitHub setup and automation label Dec 17, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Review πŸ‘€ PR that is ready to be reviewed label Dec 17, 2023
@flanakin flanakin merged commit 12eb3f2 into dev Jan 9, 2024
2 checks passed
@flanakin flanakin deleted the flanakin/dev/ver-asdotnet branch January 9, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Review πŸ‘€ PR that is ready to be reviewed Skill: DevOps GitHub setup and automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants