-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto Comment on OpenData CI Failure #1301
base: dev
Are you sure you want to change the base?
Conversation
β¦github.com/microsoft/finops-toolkit into feature/aromano-autoCommentOpenDataFailure
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I'm assuming these test lines need to be removed, right?
@@ -497,3 +497,4 @@ za north,southafricanorth,South Africa North | |||
za west,southafricawest,South Africa West | |||
zanorth,southafricanorth,South Africa North | |||
zawest,southafricawest,South Africa West | |||
test,test,test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove
@@ -503,5 +503,6 @@ function Get-OpenDataRegion | |||
,[PSCustomObject]@{ OriginalValue = 'za west'; RegionId = 'southafricawest'; RegionName = 'South Africa West'; } | |||
,[PSCustomObject]@{ OriginalValue = 'zanorth'; RegionId = 'southafricanorth'; RegionName = 'South Africa North'; } | |||
,[PSCustomObject]@{ OriginalValue = 'zawest'; RegionId = 'southafricawest'; RegionName = 'South Africa West'; } | |||
,[PSCustomObject]@{ OriginalValue = 'test'; RegionId = 'test'; RegionName = 'test'; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove
@@ -89,6 +89,7 @@ param ( | |||
$RunFailed | |||
) | |||
|
|||
throw "testing" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove
π οΈ Description
Fixes #
Fixes #961
π· Screenshots
π Checklist
π¬ How did you test this change?
πββοΈ Do any of the following that apply?
π Did you update
docs/changelog.md
?π Did you update documentation?