Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto Comment on OpenData CI Failure #1301

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

aromano2
Copy link
Contributor

@aromano2 aromano2 commented Feb 6, 2025

πŸ› οΈ Description

Fixes #
Fixes #961

πŸ“· Screenshots

πŸ“‹ Checklist

πŸ”¬ How did you test this change?

  • 🀏 Lint tests
  • 🀞 PS -WhatIf / az validate
  • πŸ‘ Manually deployed + verified
  • πŸ’ͺ Unit tests
  • πŸ™Œ Integration tests

πŸ™‹β€β™€οΈ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🀏 The change is less than 20 lines of code.

πŸ“‘ Did you update docs/changelog.md?

  • βœ… Updated changelog (required for dev PRs)
  • ➑️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

πŸ“– Did you update documentation?

  • βœ… Public docs in docs (required for dev)
  • βœ… Internal dev docs in src (required for dev)
  • ➑️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@microsoft microsoft deleted a comment from github-actions bot Feb 6, 2025
@microsoft microsoft deleted a comment from github-actions bot Feb 6, 2025
Copy link

github-actions bot commented Feb 6, 2025

⚠️ Open Data CI task failed: https://github.com/microsoft/finops-toolkit/actions/runs/13185859132

@flanakin flanakin added this to the 2025-03 - March milestone Feb 8, 2025
Copy link
Collaborator

@flanakin flanakin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm assuming these test lines need to be removed, right?

@@ -497,3 +497,4 @@ za north,southafricanorth,South Africa North
za west,southafricawest,South Africa West
zanorth,southafricanorth,South Africa North
zawest,southafricawest,South Africa West
test,test,test
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

@@ -503,5 +503,6 @@ function Get-OpenDataRegion
,[PSCustomObject]@{ OriginalValue = 'za west'; RegionId = 'southafricawest'; RegionName = 'South Africa West'; }
,[PSCustomObject]@{ OriginalValue = 'zanorth'; RegionId = 'southafricanorth'; RegionName = 'South Africa North'; }
,[PSCustomObject]@{ OriginalValue = 'zawest'; RegionId = 'southafricawest'; RegionName = 'South Africa West'; }
,[PSCustomObject]@{ OriginalValue = 'test'; RegionId = 'test'; RegionName = 'test'; }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

@@ -89,6 +89,7 @@ param (
$RunFailed
)

throw "testing"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

@flanakin flanakin added Needs: Review πŸ‘€ PR that is ready to be reviewed Needs: Attention πŸ‘‹ Issue or PR needs to be reviewed by the author or it will be closed due to no activity and removed Needs: Review πŸ‘€ PR that is ready to be reviewed labels Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Attention πŸ‘‹ Issue or PR needs to be reviewed by the author or it will be closed due to no activity Skill: DevOps GitHub setup and automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically comment on Open Data PR's when unit tests fail
3 participants