-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Azure Data Explorer support #1079
Conversation
Co-authored-by: Michael Flanakin <[email protected]>
Co-authored-by: Michael Flanakin <[email protected]>
Co-authored-by: Michael Flanakin <[email protected]>
@flanakin, the recommendations table schema is very specific to the Cost Management commitments recommendations. Ideally, we would merge Advisor + custom ARG-based recommendations into the same table, but the schema must become generic enough to accommodate them. See a more generic recommendations schema suggestion in the hack24 branch. The ADF pipeline for exporting these recommendations is ready and has been thoroughly tested. It would be great if we launch everything together. Let's discuss a common schema for Advisor-like and ACM recommendations. |
Yes, I know. I was going to merge with the other one, but didn't want to take even longer to get the foundational work done when I didn't have a full understanding of needs coming from other recommendations. I figured we'd do that as part of bringing in Advisor recommendations. Let me know if you see anything concerning. |
@flanakin, I noticed you said you would update the changelog in a future PR, but this PR is going into the dev branch. All dev branch PRs must have changelog entries to be ready for the next release. Either update the PR to target a feature branch or add a changelog entry to this PR. |
@flanakin, I noticed you said you would update documentation in a future PR, but this PR is going into the dev branch. All dev branch PRs must have applicable documentation updated to be ready for the next release. Either update the PR to target a feature branch or update the documentation in this PR. |
π οΈ Description
Add Azure Data Explorer ingestion
π Checklist
π¬ How did you test this change?
πββοΈ Do any of the following that apply?
π Did you update
docs/changelog.md
?π Did you update documentation?