Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azure Data Explorer support #1079

Merged
merged 60 commits into from
Nov 5, 2024
Merged

Add Azure Data Explorer support #1079

merged 60 commits into from
Nov 5, 2024

Conversation

flanakin
Copy link
Collaborator

πŸ› οΈ Description

Add Azure Data Explorer ingestion

πŸ“‹ Checklist

πŸ”¬ How did you test this change?

  • 🀏 Lint tests
  • 🀞 PS -WhatIf / az validate
  • πŸ‘ Manually deployed + verified
  • πŸ’ͺ Unit tests
  • πŸ™Œ Integration tests

πŸ™‹β€β™€οΈ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🀏 The change is less than 20 lines of code.

πŸ“‘ Did you update docs/changelog.md?

  • βœ… Updated changelog (required for dev PRs)
  • ➑️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

πŸ“– Did you update documentation?

  • βœ… Public docs in docs (required for dev)
  • βœ… Internal dev docs in src (required for dev)
  • ➑️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

flanakin and others added 30 commits June 29, 2023 09:55
Co-authored-by: Michael Flanakin <[email protected]>
@helderpinto
Copy link
Member

@flanakin, the recommendations table schema is very specific to the Cost Management commitments recommendations. Ideally, we would merge Advisor + custom ARG-based recommendations into the same table, but the schema must become generic enough to accommodate them. See a more generic recommendations schema suggestion in the hack24 branch. The ADF pipeline for exporting these recommendations is ready and has been thoroughly tested. It would be great if we launch everything together. Let's discuss a common schema for Advisor-like and ACM recommendations.

@flanakin
Copy link
Collaborator Author

@flanakin, the recommendations table schema is very specific to the Cost Management commitments recommendations. Ideally, we would merge Advisor + custom ARG-based recommendations into the same table, but the schema must become generic enough to accommodate them. See a more generic recommendations schema suggestion in the hack24 branch. The ADF pipeline for exporting these recommendations is ready and has been thoroughly tested. It would be great if we launch everything together. Let's discuss a common schema for Advisor-like and ACM recommendations.

Yes, I know. I was going to merge with the other one, but didn't want to take even longer to get the foundational work done when I didn't have a full understanding of needs coming from other recommendations. I figured we'd do that as part of bringing in Advisor recommendations. Let me know if you see anything concerning.

@arthurclares arthurclares merged commit ba332ab into dev Nov 5, 2024
1 of 2 checks passed

@flanakin, I noticed you said you would update the changelog in a future PR, but this PR is going into the dev branch. All dev branch PRs must have changelog entries to be ready for the next release. Either update the PR to target a feature branch or add a changelog entry to this PR.

@flanakin, I noticed you said you would update documentation in a future PR, but this PR is going into the dev branch. All dev branch PRs must have applicable documentation updated to be ready for the next release. Either update the PR to target a feature branch or update the documentation in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Review πŸ‘€ PR that is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Hubs] ADX table – Create cost details table
4 participants