Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hubs][Docs] Broken links in hub deployment steps #468

Closed
flanakin opened this issue Nov 29, 2023 · 2 comments · Fixed by #469
Closed

[Hubs][Docs] Broken links in hub deployment steps #468

flanakin opened this issue Nov 29, 2023 · 2 comments · Fixed by #469
Assignees
@flanakin
Labels
Skill: Documentation Documentation updates Tool: FinOps hubs Data pipeline solution Type: Bug 🐛 Something isn't working
Milestone
0.2

Comments

@flanakin
Copy link
Collaborator

flanakin commented Nov 29, 2023 •
edited
Loading

🐛 Problem

Power BI links in steps 5 and 6 in the hub deployment steps are broken.

Reported by @mutansee

👣 Repro steps

  1. Go to https://microsoft.github.io/finops-toolkit/hubs#-get-started-with-hubs
  2. Click on the PBI links in step 5 or the link in step 6.

All links lead to 404 errors.

🤔 Expected

Should link to the respective PBI pages.

🙋‍♀️ Ask for the community

We could use your help:

  1. Please vote this issue up (👍) to prioritize it.
  2. Leave comments to help us solidify the vision.
@flanakin flanakin added Type: Bug 🐛 Something isn't working Needs: Triage 🔍 Untriaged issue needs to be reviewed labels Nov 29, 2023
@flanakin flanakin self-assigned this Nov 29, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added Tool: FinOps hubs Data pipeline solution labels Nov 29, 2023
@flanakin flanakin added Skill: Documentation Documentation updates and removed Needs: Triage 🔍 Untriaged issue needs to be reviewed labels Nov 29, 2023
@flanakin flanakin added this to the 0.1.2 milestone Nov 29, 2023
flanakin added a commit that referenced this issue Nov 29, 2023
@flanakin
Fix broken links
aa7ba2a 
Fixes #468
@flanakin flanakin mentioned this issue Nov 29, 2023
Merged
@flanakin
Copy link
Collaborator Author

@allcontributors add @mutansee for bug

@allcontributors allcontributors bot mentioned this issue Nov 29, 2023
Merged
@allcontributors AllContributors
Copy link
Contributor

@flanakin

I've put up a pull request to add @mutansee! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flanakin flanakin

Labels
Skill: Documentation Documentation updates Tool: FinOps hubs Data pipeline solution Type: Bug 🐛 Something isn't working
Projects
None yet
Milestone
0.2
Development

Successfully merging a pull request may close this issue.

Fix broken links in docs microsoft/finops-toolkit
1 participant
@flanakin