Fix broken links

Fixes #468
microsoft · Nov 29, 2023 · aa7ba2a · aa7ba2a
1 parent 4fb04b5
commit aa7ba2a
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 15 deletions.
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -8,6 +8,7 @@
     "FinOps",
     "Lookback",
     "MOSA",
+    "msexports",
     "PBIX",
     "Quickstart",
     "quickstarts",

diff --git a/docs/changelog.md b/docs/changelog.md
@@ -180,8 +180,8 @@ Legend:
 > ➕ Added:
 >
 > 1. [FinOps hub template](./finops-hub/README.md) to deploy a storage account and Data Factory instance.
-> 2. [Cost summary report](./finops-hub/reports/cost-summary.md) for various out-of-the-box cost breakdowns.
-> 3. [Commitment discounts report](./finops-hub/reports/commitment-discounts.md) for commitment-based discount reports.
+> 2. [Cost summary report](./power-bi/cost-summary.md) for various out-of-the-box cost breakdowns.
+> 3. [Commitment discounts report](./power-bi/commitment-discounts.md) for commitment-based discount reports.
 
 🦾 Bicep modules
 {: .fs-5 .fw-500 .mt-4 mb-0 }

diff --git a/docs/finops-hub/README.md b/docs/finops-hub/README.md
@@ -85,7 +85,7 @@ Once deployed, you can report on the data in Power BI or by connecting to the st
 <img alt="Screenshot of the services cost report" style="max-width:200px" src="https://user-images.githubusercontent.com/399533/216882700-4e04b589-0580-4e49-9b40-9f5948792975.png">
 <img alt="Screenshot of the commitment-based discounts coverage report" style="max-width:200px" src="https://user-images.githubusercontent.com/399533/216882916-bb7ecfa3-d092-4ae2-88e1-7a0425c14dca.png">
 
-[Browse reports](./reports/README.md){: .btn .mt-2 .mb-4 .mb-md-0 .mr-4 }
+[Browse reports](../power-bi/README.md){: .btn .mt-2 .mb-4 .mb-md-0 .mr-4 }
 [See the template](./template.md){: .btn .mt-2 .mb-4 .mb-md-0 .mr-4 }
 
 <br>
@@ -95,7 +95,7 @@ Once deployed, you can report on the data in Power BI or by connecting to the st
 1. Register the Microsoft.EventGrid and Microsoft.CostManagementExports resource providers. See [Register a resource provider](https://docs.microsoft.com/azure/azure-resource-manager/management/resource-providers-and-types#register-resource-provider) for details.
 2. [Deploy the **finops-hub** template](../resources/deploy.md).
 
-   [![Deploy To Azure](https://raw.githubusercontent.com/Azure/azure-quickstart-templates/master/1-CONTRIBUTION-GUIDE/images/deploytoazure.svg?sanitize=true)](https://aka.ms/finops/hubs/deploy) &nbsp; [![Deploy To Azure US Gov](https://raw.githubusercontent.com/Azure/azure-quickstart-templates/master/1-CONTRIBUTION-GUIDE/images/deploytoazuregov.svg?sanitize=true)](https://aka.ms/finops/hubs/deploy/gov) &nbsp; [![Deploy To Azure China](https://raw.githubusercontent.com/Azure/azure-quickstart-templates/master/1-CONTRIBUTION-GUIDE/images/deploytoazurechina.svg?sanitize=true)](https://aka.ms/finops/hubs/deploy/china) 
+   [![Deploy To Azure](https://raw.githubusercontent.com/Azure/azure-quickstart-templates/master/1-CONTRIBUTION-GUIDE/images/deploytoazure.svg?sanitize=true)](https://aka.ms/finops/hubs/deploy) &nbsp; [![Deploy To Azure US Gov](https://raw.githubusercontent.com/Azure/azure-quickstart-templates/master/1-CONTRIBUTION-GUIDE/images/deploytoazuregov.svg?sanitize=true)](https://aka.ms/finops/hubs/deploy/gov) &nbsp; [![Deploy To Azure China](https://raw.githubusercontent.com/Azure/azure-quickstart-templates/master/1-CONTRIBUTION-GUIDE/images/deploytoazurechina.svg?sanitize=true)](https://aka.ms/finops/hubs/deploy/china)
 
 3. [Create a new cost export](https://learn.microsoft.com/azure/cost-management-billing/costs/tutorial-export-acm-data?tabs=azure-portal) using the following settings:
 
@@ -114,9 +114,9 @@ Once deployed, you can report on the data in Power BI or by connecting to the st
    - Use the **Run now** command at the top of the Cost Management Exports page.
    - Your data should be available within 15 minutes or so, depending on how big your account is.
 5. Download one or more of the available Power BI starter templates from the [latest release](https://github.com/microsoft/finops-toolkit/releases):
-   - [Cost summary](./reports/cost-summary.md) for standard cost roll-ups.
-   - [Commitment discounts](./reports/commitment-discounts.md) for commitment-based savings utilization and coverage.
-6. [Connect Power BI to your hub](./reports/README.md#setup-a-finops-hub-report)
+   - [Cost summary](../power-bi/cost-summary.md) for standard cost roll-ups.
+   - [Commitment discounts](../power-bi/commitment-discounts.md) for commitment-based savings utilization and coverage.
+6. [Connect Power BI to your hub](../power-bi/README.md#-connect-to-your-data)
 
 If you run into any issues, see [Troubleshooting Power BI reports](./troubleshooting.md).
 
@@ -128,11 +128,11 @@ After deploying a hub instance, there are several ways for you to get started:
 
 1. Customize the built-in Power BI reports.
 
-   Our Power BI reports are starter templates and intended to be customized. We encourage you to customize as needed. [Learn more](./reports/README.md).
+   Our Power BI reports are starter templates and intended to be customized. We encourage you to customize as needed. [Learn more](../power-bi/README.md).
 
 2. Create your own Power BI reports.
 
-   If you'd like to create your own reports or add cost data to an existing report, you can either [copy queries from a pre-built report](./reports/README.md#setup-a-finops-hub-report) or [connect manually](./reports/README.md#connect-manually) using the Azure Data Lake Storage Gen2 connector.
+   If you'd like to create your own reports or add cost data to an existing report, you can either [copy queries from a pre-built report](../power-bi/README.md#setup-a-finops-hub-report) or [connect manually](../power-bi/README.md#connect-manually) using the Azure Data Lake Storage Gen2 connector.
 
    <!-- NOTE TO CONTRIBUTORS: Keep this info note in sync with the same one under #3 below. -->
 

diff --git a/docs/power-bi/README.md b/docs/power-bi/README.md
@@ -27,7 +27,7 @@ Accelerate your analytics efforts with simple, targeted reports. Summarize and b
 
 ---
 
-{% include_relative _intro.md %}
+<!-- markdownlint-disable-line --> {% include_relative _intro.md %}
 
 <br>
 
@@ -99,15 +99,15 @@ All FinOps toolkit reports, come with sample data to explore without connecting
 
    ![Screenshot of the Transform data button in the Power BI Desktop toolbar.](https://user-images.githubusercontent.com/399533/216573265-fa76828f-c9a2-497d-ae1e-19b55fef412c.png)
 
-2. Select **Queries** > **🛠️ Setup** > **▶️ START HERE** and follow the instructions.
+2. Select **Queries** > **🛠️ Setup** > **Instructions** > **▶ START HERE** and follow the instructions.
 
    To connect to a FinOps hub instance, you will need the `storageUrlForPowerBI` value from the deployment outputs. Make sure you have the [Storage Blob Data Reader role](https://learn.microsoft.com/azure/role-based-access-control/built-in-roles#storage-blob-data-reader) on the storage account so you can access the data.
 
-   ![Screenshot of instructions to connect to a FinOps hub](https://github.com/microsoft/finops-toolkit/assets/399533/3f53e501-0c83-4362-be6d-f276cf39acaa)
+   ![Screenshot of instructions to connect to a FinOps hub](https://github.com/microsoft/finops-toolkit/assets/399533/5582b428-e811-4d7e-83d0-4a8fbb905d30)
 
    To connect to the Cost Management connector, you will need the billing account ID and/or billing profile ID. You can find this in [Cost Management configuration settings](https://aka.ms/costmgmt/config) > **Properties**.
 
-   ![Screenshot of instructions to connect to the Cost Management connector](https://github.com/microsoft/finops-toolkit/assets/399533/3bc5eb22-a7e7-4d13-a3a3-91d0bc48800e)
+   ![Screenshot of instructions to connect to the Cost Management connector](https://github.com/microsoft/finops-toolkit/assets/399533/efeb85d6-cdd3-40f8-a501-e1959fdb1d4f)
 
 3. Select **Close & Apply** in the toolbar and allow Power BI to refresh to see your data.
 

diff --git a/docs/power-bi/setup.md b/docs/power-bi/setup.md
@@ -28,7 +28,7 @@ Publish new Power BI reports based on FinOps toolkit starter kits, extend them t
 
 ---
 
-{% include_relative _intro.md %}
+<!-- markdownlint-disable-line --> {% include_relative _intro.md %}
 
 Use the guides below to connect and customize FinOps toolkit and other Power BI reports.
 
@@ -64,6 +64,8 @@ The FinOps toolkit Power BI reports include pre-configured visuals, but are not
      </blockquote>
    - **CM connector** settings are required for any reports that rely on data not supported in FinOps hubs yet (e.g., reservation recommendations). Be sure to also supply those settings in the next section.
 
+   ![Screenshot of instructions to connect to a FinOps hub](https://github.com/microsoft/finops-toolkit/assets/399533/5582b428-e811-4d7e-83d0-4a8fbb905d30)
+
 5. If you selected `Cost Management connector`, set the following properties in the **🛠️ Setup** > **CM connector** folder:
 
    - **Billing Account ID** is your EA enrollment number or MCA billing account ID.
@@ -76,7 +78,7 @@ The FinOps toolkit Power BI reports include pre-configured visuals, but are not
        _Power BI reports can only support 35GB of data (~$16M in raw cost details). You may need to adjust the number of months in your report to fit within this limit._
      </blockquote>
 
-   ![Screenshot of instructions to connect to the Cost Management connector](https://github.com/microsoft/finops-toolkit/assets/399533/3bc5eb22-a7e7-4d13-a3a3-91d0bc48800e)
+   ![Screenshot of instructions to connect to the Cost Management connector](https://github.com/microsoft/finops-toolkit/assets/399533/efeb85d6-cdd3-40f8-a501-e1959fdb1d4f)
 
 6. Select the **Close & Apply** to save your settings.
 
@@ -187,7 +189,9 @@ The Cost Management connector provides separate queries for actual (billed) and
 
 If interested in custom columns and measures, see [Copy queries from a toolkit report](#-copy-queries-from-a-toolkit-report) for required steps.
 
+<!--
 See [Queries and datasets](#️-queries-and-datasets) below for additional details.
+-->
 
 <br>