Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix method ordering, xmldoc, and remove obsolete XUnit verifiers #367

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix method ordering, xmldoc, and remove obsolete XUnit verifiers #367

wants to merge 2 commits into from
+62 −63

Conversation

jviau
Copy link
Member

@jviau jviau commented Jan 25, 2025

Fixing some warnings to get back to 0 warnings

  • Re-orders a couple methods
  • Fixes xmldoc
  • Removes obsolete XUnit analysis packages, following guidance on what to replace with.
    • this exposed an anti-pattern in one of the analyzers, add a TODO comment regarding it.

@jviau jviau requested a review from cgillum January 25, 2025 00:04
@jviau jviau requested a review from cgillum January 27, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgillum cgillum Awaiting requested review from cgillum

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jviau @cgillum