add comments

microsoft · Nov 12, 2023 · 761adbe · 761adbe
1 parent 5a05eb9
commit 761adbe
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/test/Client/Core.Tests/Entities/EntityMetadataTests.cs b/test/Client/Core.Tests/Entities/EntityMetadataTests.cs
@@ -39,7 +39,7 @@ public void Serialize_StateNotIncluded()
             LockedBy = lockedBy,
         };
 
-        string nowStr = JsonSerializer.Serialize(now);
+        string nowStr = JsonSerializer.Serialize(now); // STJ drops trailing zeroes from dates. see: https://github.com/microsoft/durabletask-dotnet/pull/239
         string json = JsonSerializer.Serialize(metadata);
         json.Should().Be($"{{\"Id\":\"{this.id}\",\"LastModifiedTime\":{nowStr},\"BacklogQueueSize\":10,\"LockedBy\""
             + $":\"{lockedBy}\"}}");
@@ -58,7 +58,7 @@ public void Serialize_StateIncluded_Int()
             LockedBy = lockedBy,
         };
 
-        string nowStr = JsonSerializer.Serialize(now);
+        string nowStr = JsonSerializer.Serialize(now); // STJ drops trailing zeroes from dates. see: https://github.com/microsoft/durabletask-dotnet/pull/239
         string json = JsonSerializer.Serialize(metadata);
         json.Should().Be($"{{\"Id\":\"{this.id}\",\"LastModifiedTime\":{nowStr},\"BacklogQueueSize\":10,\"LockedBy\""
             + $":\"{lockedBy}\",\"State\":{state}}}");
@@ -77,7 +77,7 @@ public void Serialize_StateIncluded_Object()
             LockedBy = lockedBy,
         };
 
-        string nowStr = JsonSerializer.Serialize(now);
+        string nowStr = JsonSerializer.Serialize(now); // STJ drops trailing zeroes from dates. see: https://github.com/microsoft/durabletask-dotnet/pull/239
         string json = JsonSerializer.Serialize(metadata);
         json.Should().Be($"{{\"Id\":\"{this.id}\",\"LastModifiedTime\":{nowStr},\"BacklogQueueSize\":10,\"LockedBy\""
             + $":\"{lockedBy}\",\"State\":{{\"Number\":{state.Number}}}}}");
@@ -93,7 +93,7 @@ public void Serialize_StateIncluded_Object2()
             LastModifiedTime = now,
         };
 
-        string nowStr = JsonSerializer.Serialize(now);
+        string nowStr = JsonSerializer.Serialize(now); // STJ drops trailing zeroes from dates. see: https://github.com/microsoft/durabletask-dotnet/pull/239
         string json = JsonSerializer.Serialize(metadata);
         json.Should().Be($"{{\"Id\":\"{this.id}\",\"LastModifiedTime\":{nowStr},\"State\":"
             + $"{{\"Number\":{state.Number}}}}}");
@@ -109,7 +109,7 @@ public void Serialize_StateNotIncluded_NonGeneric()
             LastModifiedTime = now,
         };
 
-        string nowStr = JsonSerializer.Serialize(now);
+        string nowStr = JsonSerializer.Serialize(now); // STJ drops trailing zeroes from dates. see: https://github.com/microsoft/durabletask-dotnet/pull/239
         string json = JsonSerializer.Serialize(metadata);
         json.Should().Be($"{{\"Id\":\"{this.id}\",\"LastModifiedTime\":{nowStr}}}");
     }
@@ -125,7 +125,7 @@ public void Serialize_StateIncluded_NonGeneric()
             LastModifiedTime = now,
         };
 
-        string nowStr = JsonSerializer.Serialize(now);
+        string nowStr = JsonSerializer.Serialize(now); // STJ drops trailing zeroes from dates. see: https://github.com/microsoft/durabletask-dotnet/pull/239
         string json = JsonSerializer.Serialize(metadata);
         json.Should().Be($@"{{""Id"":""{this.id}"",""LastModifiedTime"":{nowStr},""State"":""{{\u0022Number\u0022:{state.Number}}}""}}");
     }