feat: added seek & rate to SpeakerAudioDestination #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
calinalexandru
force-pushed
the
feat/add-seek-and-rate
branch
from
8eb778d to
829f3fa
Compare
|
@calinalexandru Thanks for submitting this! The code looks good, I'll run this through some manual tests and give the team and chance to look at it. |
yulin-li
reviewed
Mar 22, 2022
| @@ -52,6 +52,7 @@ export class SpeakerAudioDestination implements IAudioDestination, IPlayer { | |||
| this.privId = audioDestinationId ? audioDestinationId : createNoDashGuid(); | |||
| this.privIsPaused = false; | |||
| this.privIsClosed = false; | |||
| this.privAudio = new Audio(); | |||
There was a problem hiding this comment.
The undefined value of privaAudio means the playback is not supported (e.g. unsupported format, see line 134). This would break some current logic. So pls revert.
There was a problem hiding this comment.
@yulin-li can you please elaborate your response? From what I can see calling method format will re-initialize privAudio so it doesn't matter if I also set it constructor. I'm only trying to understand if there's a better approach than re-adding undefined checks (following null object pattern). Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
In my application I need to be able to adjust seek & rate of the Audio element, and I don't believe there's a reason for them not to be here.
Also, I set
privAudio = new Audio()from the constructor to prevent unnecessary undefined check.Went ahead and removed some of those checks, although, more expressions can be simplified in the class.