Fix PEP8 code style and misspelling issues #53
Conversation
|
I still need to do more validations and re-run all tests, but at least most of applicable PEP8 issues were fixe. I tried to be consistent on line breaks, but I may have missed a few things. There were some exceptions that we can discuss, specially regarding long lines that contains URLs. |
| blob_client = BlobClient.from_blob_url( | ||
| self.details.output_data_uri) | ||
| blob_uri = self.workspace._get_linked_storage_sas_uri( | ||
| blob_client.container_name, blob_client.blob_name) | ||
| payload = download_blob(blob_uri) |
There was a problem hiding this comment.
I think we should run pycodestyle or flake8 on this repo and it will point out pep8 style issues as well.
There was a problem hiding this comment.
To autofix issues 'black' is a tool to help. It isn;t 100% pep8 compliant but there is way around it or autopep8or yapf
There was a problem hiding this comment.
Yes, we have another issue #50 that will address that.
For now, I manually ran and fixed the issues using pylint and flake8.
There was a problem hiding this comment.
Did you find a specific style issue with the highlighted code?
Is there a better way to break those lines so they will be under 80 chars?
| blob_client = BlobClient.from_blob_url( | ||
| self.details.output_data_uri) | ||
| blob_uri = self.workspace._get_linked_storage_sas_uri( | ||
| blob_client.container_name, blob_client.blob_name) | ||
| payload = download_blob(blob_uri) |
There was a problem hiding this comment.
I think we should run pycodestyle or flake8 on this repo and it will point out pep8 style issues as well.
|
Issue #50 that will address running linting tools on the repo with the CI/CD pipeline |
|
I ran the unit tests and code is running fine. |
* auto correction with yapf and black * styling for job.py * pep8 for workspace.py * pep8 storage.py * pep8: streaming_problem * pep8: solvers.py * pep8 problem.py * pep8: termp.py * pep8: toshiba/solvers.py * pep8: onequibit/solvers * clean up * pep8 init * setup.py * nit
This PR fixes hundreds of PEP8/Pylint and some misspelling issues in preparation #50 (enforce code style guidelines in the CI/CD pipeline)