fix: Fixing one instance of async vulnerability #1142
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR partially addresses this dependabot alert about using a vulnerable version of "async." Where possible, it updates the dependencies we have that rely on async and bumps them to use a current, secure version of the package. For the case where this is not possible, we are choosing to resolve this dependabot alert without fixing them, as the amount of work required to make a fix is not logical for the low risk that this vulnerability poses for us.
This dependency was updated by removing and re-adding the async@^2.0 entry of the lockfile, since our caret version, when refreshed, would bump up to a secure version of async (2.6.4).
Motivation
Keeping dependencies up-to-date.
Context
This change leaves a few dependencies on async at lower-than-secure versions. Secure versions of async are specifically 2.6.4, and then 3.2.3 and above. However, there are other dependencies of ours which rely on things which rely on things (and so on)... which rely on async at a vulnerable version. Namely, tfx-cli at its latest version relies on async ^1.4.0. Additionally, tfx-cli has a dependency on prompt, which relies on async ~0.9.0, and which also has its own dependency on winston 2.x, which uses async ~1.0.0.
Options considered:
Pull request checklist
yarn test
)<rootDir>/test-results/unit/coverage
yarn precheckin
)