Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ContentIsland page with Helmet demo (requires WinAppSDK 1.7 APIs) #1743

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

JesseCol
Copy link

@JesseCol JesseCol commented Feb 5, 2025

NOTE: Do not merge until WinAppSDK is updated to 1.7.

Description

Adds a ContentIsland page that uses Scene Node APIs to show a 3D model of a helmet.

Motivation and Context

This shows how apps can use ChildSiteLink to attach a ContentIsland in a Xaml app.

How Has This Been Tested?

  • Built and ran packaged
  • Built and ran unpackaged

Screenshots (if appropriate):

ContentIslandHelmet

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

ChildSiteLink childSiteLink = ChildSiteLink.Create(parentIsland, placementVisual);

placementVisual.Size = size;
childSiteLink.ActualSize = size;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also need to set the childSiteLink's LocalToParentTransform to match the transform from the placementVisual to the parentIsland's rootVisual.

Copy link

@jeffstall jeffstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just check into the experimental branch now, and then merge that branch into main once WASDK 1.7.0 is GA?

@niels9001
Copy link
Contributor

@JesseCol I've updated your PR to resolve major conflicts due to #1732. I've also tweaked the XAML a bit to remove unnecessary XAML and used a WrapPanel vs. the Grid so things are easier to see on a wide-screens.

@JesseCol
Copy link
Author

JesseCol commented Feb 7, 2025

Can we just check into the experimental branch now, and then merge that branch into main once WASDK 1.7.0 is GA?

Hi, there's no dedicated experimental branch for this repo (WinUI-Gallery). I've heard there's a new plan for WindowsAppSDK-Samples where we'll check in code that uses experimental APIs to main, and then conditionally compile that code. Maybe we can do something similar here.

@marcelwgn
Copy link
Contributor

Can we just check into the experimental branch now, and then merge that branch into main once WASDK 1.7.0 is GA?

Hi, there's no dedicated experimental branch for this repo (WinUI-Gallery). I've heard there's a new plan for WindowsAppSDK-Samples where we'll check in code that uses experimental APIs to main, and then conditionally compile that code. Maybe we can do something similar here.

For that, we essentially only need to check for WinUI 1.7 in the csproj and .cs file right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants