Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOM update MessageEventTarget missed this parameters #61086

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

DOM update MessageEventTarget missed this parameters #61086

wants to merge 2 commits into from
+4 −4

Conversation

sandersn
Copy link
Member

While trying to update typescript-dom-lib-generator so that it generates the correct types for MessageEventTarget's this parameters, I realised that my manual fix missed a couple. They're not required to make the known problem code in DT/top400 compile, but all the this parameters should have consistent types.

Of course, the whole thing is so fragile that I want to run tests as I figure out how to make dom-lib-generator generate the correct types, so that I can know if I need an even-more-complex fix.

@sandersn
Copy link
Member Author

@typescript-bot test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 30, 2025 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top400 ✅ Started ✅ Results
user test this ✅ Started ✅ Results
run dt ✅ Started ✅ Results
perf test this faster ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

@sandersn Here are the results of running the user tests with tsc comparing main and refs/pull/61086/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

Hey @sandersn, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

@typescript-bot
Copy link
Collaborator

@sandersn
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 34 34 ~ ~ ~ p=1.000 n=6
Symbols 62,390 62,390 ~ ~ ~ p=1.000 n=6
Types 50,395 50,395 ~ ~ ~ p=1.000 n=6
Memory used 194,436k (± 0.98%) 194,935k (± 1.02%) ~ 193,110k 196,794k p=0.689 n=6
Parse Time 1.31s (± 0.39%) 1.31s (± 1.48%) ~ 1.27s 1.32s p=0.929 n=6
Bind Time 0.73s 0.73s ~ ~ ~ p=1.000 n=6
Check Time 9.75s (± 0.31%) 9.77s (± 0.47%) ~ 9.71s 9.82s p=0.467 n=6
Emit Time 2.73s (± 0.59%) 2.73s (± 0.94%) ~ 2.70s 2.77s p=1.000 n=6
Total Time 14.52s (± 0.22%) 14.54s (± 0.39%) ~ 14.46s 14.61s p=0.809 n=6
angular-1 - node (v18.15.0, x64)
Errors 37 37 ~ ~ ~ p=1.000 n=6
Symbols 948,488 948,488 ~ ~ ~ p=1.000 n=6
Types 411,006 411,006 ~ ~ ~ p=1.000 n=6
Memory used 1,225,430k (± 0.00%) 1,225,430k (± 0.00%) ~ 1,225,368k 1,225,476k p=0.936 n=6
Parse Time 6.63s (± 0.93%) 6.63s (± 1.04%) ~ 6.53s 6.72s p=1.000 n=6
Bind Time 1.89s (± 0.58%) 1.89s (± 0.43%) ~ 1.88s 1.90s p=0.666 n=6
Check Time 32.01s (± 0.55%) 31.93s (± 0.30%) ~ 31.83s 32.09s p=0.296 n=6
Emit Time 15.22s (± 0.46%) 15.16s (± 0.89%) ~ 14.95s 15.33s p=0.371 n=6
Total Time 55.76s (± 0.33%) 55.62s (± 0.35%) ~ 55.43s 55.91s p=0.230 n=6
mui-docs - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 2,447,088 2,447,088 ~ ~ ~ p=1.000 n=6
Types 898,553 898,553 ~ ~ ~ p=1.000 n=6
Memory used 2,307,933k (± 0.00%) 2,307,955k (± 0.00%) ~ 2,307,934k 2,307,976k p=0.230 n=6
Parse Time 8.93s (± 0.25%) 8.93s (± 0.19%) ~ 8.91s 8.96s p=0.804 n=6
Bind Time 2.17s (± 0.35%) 2.18s (± 0.24%) ~ 2.17s 2.18s p=0.247 n=6
Check Time 74.30s (± 0.57%) 74.24s (± 0.46%) ~ 73.81s 74.59s p=1.000 n=6
Emit Time 0.28s (± 1.47%) 0.28s (± 3.19%) ~ 0.27s 0.29s p=0.787 n=6
Total Time 85.68s (± 0.52%) 85.63s (± 0.41%) ~ 85.20s 85.95s p=1.000 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,229,397 1,229,397 ~ ~ ~ p=1.000 n=6
Types 267,085 267,085 ~ ~ ~ p=1.000 n=6
Memory used 2,607,988k (±14.42%) 3,094,937k (± 0.01%) 🔻+486,949k (+18.67%) 3,094,485k 3,095,535k p=0.005 n=6
Parse Time 6.65s (± 1.38%) 6.82s (± 0.99%) +0.17s (+ 2.51%) 6.74s 6.92s p=0.020 n=6
Bind Time 2.17s (± 1.28%) 2.16s (± 1.74%) ~ 2.09s 2.20s p=0.810 n=6
Check Time 42.74s (± 0.56%) 42.91s (± 0.26%) ~ 42.77s 43.08s p=0.128 n=6
Emit Time 3.52s (± 3.20%) 3.44s (± 2.24%) ~ 3.29s 3.50s p=0.470 n=6
Total Time 55.07s (± 0.70%) 55.33s (± 0.25%) ~ 55.17s 55.51s p=0.298 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,229,397 1,229,397 ~ ~ ~ p=1.000 n=6
Types 267,085 267,085 ~ ~ ~ p=1.000 n=6
Memory used 3,039,468k (± 9.76%) 2,917,490k (±12.87%) ~ 2,431,883k 3,160,702k p=0.173 n=6
Parse Time 7.00s (± 1.21%) 6.97s (± 1.54%) ~ 6.78s 7.08s p=0.748 n=6
Bind Time 2.14s (± 0.87%) 2.14s (± 2.55%) ~ 2.10s 2.24s p=0.295 n=6
Check Time 42.82s (± 0.36%) 42.72s (± 0.24%) ~ 42.59s 42.88s p=0.378 n=6
Emit Time 3.48s (± 2.14%) 3.56s (± 5.93%) ~ 3.32s 3.91s p=0.575 n=6
Total Time 55.43s (± 0.54%) 55.41s (± 0.25%) ~ 55.21s 55.57s p=0.810 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 263,074 263,074 ~ ~ ~ p=1.000 n=6
Types 106,881 106,881 ~ ~ ~ p=1.000 n=6
Memory used 441,323k (± 0.01%) 441,320k (± 0.01%) ~ 441,225k 441,375k p=0.936 n=6
Parse Time 2.91s (± 0.57%) 2.90s (± 0.47%) ~ 2.88s 2.92s p=0.217 n=6
Bind Time 1.11s 1.11s ~ ~ ~ p=1.000 n=6
Check Time 15.78s (± 0.37%) 15.81s (± 0.09%) ~ 15.80s 15.84s p=0.258 n=6
Emit Time 1.33s (± 0.79%) 1.32s (± 0.88%) ~ 1.31s 1.34s p=0.619 n=6
Total Time 21.12s (± 0.23%) 21.14s (± 0.09%) ~ 21.10s 21.15s p=0.466 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 70 70 ~ ~ ~ p=1.000 n=6
Symbols 226,113 226,113 ~ ~ ~ p=1.000 n=6
Types 94,488 94,488 ~ ~ ~ p=1.000 n=6
Memory used 371,867k (± 0.03%) 371,757k (± 0.02%) ~ 371,675k 371,824k p=0.128 n=6
Parse Time 3.62s (± 1.58%) 3.61s (± 0.79%) ~ 3.57s 3.65s p=0.567 n=6
Bind Time 1.99s (± 1.16%) 1.98s (± 1.45%) ~ 1.94s 2.01s p=0.463 n=6
Check Time 20.43s (± 0.47%) 20.47s (± 0.41%) ~ 20.38s 20.59s p=0.423 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 26.04s (± 0.40%) 26.06s (± 0.39%) ~ 25.93s 26.21s p=1.000 n=6
vscode - node (v18.15.0, x64)
Errors 3 3 ~ ~ ~ p=1.000 n=6
Symbols 3,273,582 3,273,568 -14 (- 0.00%) ~ ~ p=0.001 n=6
Types 1,125,603 1,125,603 ~ ~ ~ p=1.000 n=6
Memory used 3,347,508k (± 0.01%) 3,347,417k (± 0.01%) ~ 3,347,145k 3,347,750k p=0.689 n=6
Parse Time 14.63s (± 0.27%) 14.64s (± 0.53%) ~ 14.56s 14.77s p=1.000 n=6
Bind Time 4.60s (± 0.25%) 4.61s (± 0.56%) ~ 4.58s 4.65s p=0.871 n=6
Check Time 91.22s (± 1.82%) 89.70s (± 1.51%) ~ 88.59s 91.74s p=0.066 n=6
Emit Time 28.61s (± 3.31%) 28.70s (± 3.04%) ~ 27.36s 29.36s p=0.748 n=6
Total Time 139.06s (± 1.43%) 137.65s (± 1.08%) ~ 136.13s 140.46s p=0.173 n=6
webpack - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 292,552 292,528 -24 (- 0.01%) ~ ~ p=0.001 n=6
Types 119,125 119,113 -12 (- 0.01%) ~ ~ p=0.001 n=6
Memory used 446,025k (± 0.04%) 446,139k (± 0.02%) ~ 446,062k 446,325k p=0.230 n=6
Parse Time 5.09s (± 0.93%) 5.08s (± 1.12%) ~ 5.00s 5.16s p=0.630 n=6
Bind Time 2.21s (± 1.03%) 2.22s (± 0.96%) ~ 2.18s 2.24s p=0.222 n=6
Check Time 23.58s (± 2.32%) 23.49s (± 0.54%) ~ 23.34s 23.70s p=0.298 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 30.88s (± 1.78%) 30.79s (± 0.41%) ~ 30.68s 31.02s p=0.298 n=6
xstate-main - node (v18.15.0, x64)
Errors 5 5 ~ ~ ~ p=1.000 n=6
Symbols 555,448 555,448 ~ ~ ~ p=1.000 n=6
Types 186,146 186,146 ~ ~ ~ p=1.000 n=6
Memory used 494,591k (± 0.01%) 494,650k (± 0.01%) +58k (+ 0.01%) 494,581k 494,706k p=0.045 n=6
Parse Time 3.41s (± 0.82%) 3.41s (± 1.02%) ~ 3.37s 3.45s p=1.000 n=6
Bind Time 1.21s (± 1.71%) 1.21s (± 1.21%) ~ 1.19s 1.23s p=0.622 n=6
Check Time 19.64s (± 0.34%) 19.68s (± 0.22%) ~ 19.61s 19.72s p=0.372 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 24.26s (± 0.35%) 24.29s (± 0.14%) ~ 24.24s 24.34s p=0.423 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@typescript-bot
Copy link
Collaborator

@sandersn Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61086/merge:

Everything looks good!

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jan 31, 2025
@sandersn
Copy link
Member Author

matching dom lib generator PR: microsoft/TypeScript-DOM-lib-generator#1894

@typescript-bot test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 31, 2025 •
edited
Loading

Starting jobs; this comment will be updated as builds start and complete.

Command Status Results
test top400 ✅ Started ✅ Results
user test this ✅ Started ✅ Results
run dt ✅ Started ✅ Results
perf test this faster ✅ Started 👀 Results

@typescript-bot
Copy link
Collaborator

@sandersn Here are the results of running the user tests with tsc comparing main and refs/pull/61086/merge:

Everything looks good!

@typescript-bot
Copy link
Collaborator

Hey @sandersn, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

@typescript-bot
Copy link
Collaborator

@sandersn
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Compiler-Unions - node (v18.15.0, x64)
Errors 34 34 ~ ~ ~ p=1.000 n=6
Symbols 62,390 62,390 ~ ~ ~ p=1.000 n=6
Types 50,395 50,395 ~ ~ ~ p=1.000 n=6
Memory used 194,348k (± 0.96%) 194,331k (± 0.97%) ~ 193,100k 196,770k p=0.470 n=6
Parse Time 1.31s (± 0.39%) 1.31s (± 0.94%) ~ 1.29s 1.32s p=1.000 n=6
Bind Time 0.73s 0.73s ~ ~ ~ p=1.000 n=6
Check Time 9.76s (± 0.19%) 9.75s (± 0.33%) ~ 9.72s 9.80s p=0.519 n=6
Emit Time 2.72s (± 0.63%) 2.74s (± 1.02%) ~ 2.71s 2.79s p=0.329 n=6
Total Time 14.51s (± 0.20%) 14.52s (± 0.28%) ~ 14.49s 14.59s p=0.804 n=6
angular-1 - node (v18.15.0, x64)
Errors 37 37 ~ ~ ~ p=1.000 n=6
Symbols 948,488 948,488 ~ ~ ~ p=1.000 n=6
Types 411,006 411,006 ~ ~ ~ p=1.000 n=6
Memory used 1,225,654k (± 0.00%) 1,225,645k (± 0.00%) ~ 1,225,585k 1,225,679k p=0.574 n=6
Parse Time 7.99s (± 1.03%) 8.02s (± 1.42%) ~ 7.90s 8.13s p=0.872 n=6
Bind Time 2.28s (± 0.77%) 2.29s (± 0.33%) ~ 2.28s 2.30s p=0.325 n=6
Check Time 38.34s (± 0.71%) 38.26s (± 0.39%) ~ 38.07s 38.39s p=0.378 n=6
Emit Time 18.33s (± 0.28%) 18.26s (± 0.51%) ~ 18.14s 18.38s p=0.229 n=6
Total Time 66.95s (± 0.26%) 66.83s (± 0.26%) ~ 66.62s 67.05s p=0.199 n=6
mui-docs - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 2,447,455 2,447,455 ~ ~ ~ p=1.000 n=6
Types 898,654 898,654 ~ ~ ~ p=1.000 n=6
Memory used 2,309,915k (± 0.00%) 2,309,915k (± 0.00%) ~ 2,309,894k 2,309,938k p=1.000 n=6
Parse Time 8.94s (± 0.19%) 8.92s (± 0.20%) ~ 8.90s 8.95s p=0.164 n=6
Bind Time 2.18s (± 0.69%) 2.17s (± 0.24%) ~ 2.17s 2.18s p=1.000 n=6
Check Time 74.40s (± 0.58%) 74.33s (± 0.25%) ~ 74.06s 74.51s p=0.575 n=6
Emit Time 0.27s (± 1.89%) 0.28s (± 2.70%) ~ 0.27s 0.29s p=0.247 n=6
Total Time 85.79s (± 0.51%) 85.70s (± 0.23%) ~ 85.42s 85.89s p=0.575 n=6
self-build-src - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,229,397 1,229,397 ~ ~ ~ p=1.000 n=6
Types 267,085 267,085 ~ ~ ~ p=1.000 n=6
Memory used 2,851,822k (±13.21%) 2,973,361k (±10.02%) ~ 2,364,477k 3,096,666k p=0.936 n=6
Parse Time 6.70s (± 1.74%) 6.75s (± 1.05%) ~ 6.61s 6.79s p=1.000 n=6
Bind Time 2.15s (± 1.02%) 2.12s (± 1.05%) ~ 2.09s 2.15s p=0.092 n=6
Check Time 42.65s (± 0.34%) 42.76s (± 0.28%) ~ 42.58s 42.94s p=0.173 n=6
Emit Time 3.49s (± 3.20%) 3.48s (± 1.04%) ~ 3.44s 3.52s p=0.810 n=6
Total Time 55.01s (± 0.46%) 55.13s (± 0.29%) ~ 54.87s 55.38s p=0.936 n=6
self-build-src-public-api - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 1,229,397 1,229,397 ~ ~ ~ p=1.000 n=6
Types 267,085 267,085 ~ ~ ~ p=1.000 n=6
Memory used 2,429,412k (± 0.02%) 2,550,535k (±11.62%) ~ 2,428,616k 3,156,251k p=0.936 n=6
Parse Time 5.47s (± 0.77%) 5.46s (± 1.13%) ~ 5.40s 5.57s p=0.470 n=6
Bind Time 1.78s (± 1.11%) 1.79s (± 1.39%) ~ 1.76s 1.82s p=0.411 n=6
Check Time 35.35s (± 0.24%) 35.41s (± 0.34%) ~ 35.29s 35.64s p=0.378 n=6
Emit Time 3.03s (± 1.21%) 3.06s (± 1.41%) ~ 3.02s 3.13s p=0.378 n=6
Total Time 45.64s (± 0.18%) 45.72s (± 0.40%) ~ 45.56s 46.07s p=0.470 n=6
self-compiler - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 263,074 263,074 ~ ~ ~ p=1.000 n=6
Types 106,881 106,881 ~ ~ ~ p=1.000 n=6
Memory used 441,282k (± 0.02%) 441,269k (± 0.02%) ~ 441,132k 441,336k p=0.810 n=6
Parse Time 2.90s (± 1.19%) 2.88s (± 0.81%) ~ 2.85s 2.92s p=0.324 n=6
Bind Time 1.11s (± 0.37%) 1.11s (± 0.46%) ~ 1.11s 1.12s p=0.114 n=6
Check Time 15.79s (± 0.33%) 15.81s (± 0.45%) ~ 15.73s 15.92s p=0.807 n=6
Emit Time 1.31s (± 1.15%) 1.32s (± 0.88%) ~ 1.31s 1.34s p=0.505 n=6
Total Time 21.10s (± 0.37%) 21.13s (± 0.30%) ~ 21.08s 21.24s p=0.872 n=6
ts-pre-modules - node (v18.15.0, x64)
Errors 70 70 ~ ~ ~ p=1.000 n=6
Symbols 226,113 226,113 ~ ~ ~ p=1.000 n=6
Types 94,488 94,488 ~ ~ ~ p=1.000 n=6
Memory used 371,726k (± 0.01%) 371,773k (± 0.04%) ~ 371,654k 372,021k p=1.000 n=6
Parse Time 3.61s (± 0.59%) 3.60s (± 1.02%) ~ 3.55s 3.64s p=0.627 n=6
Bind Time 1.96s (± 0.91%) 1.97s (± 0.75%) ~ 1.95s 1.99s p=0.256 n=6
Check Time 20.36s (± 0.40%) 20.47s (± 0.30%) +0.11s (+ 0.52%) 20.37s 20.54s p=0.037 n=6
Emit Time 0.00s (±244.70%) 0.00s ~ ~ ~ p=0.405 n=6
Total Time 25.94s (± 0.32%) 26.04s (± 0.40%) ~ 25.88s 26.16s p=0.092 n=6
vscode - node (v18.15.0, x64)
Errors 3 3 ~ ~ ~ p=1.000 n=6
Symbols 3,273,541 3,273,527 -14 (- 0.00%) ~ ~ p=0.001 n=6
Types 1,125,648 1,125,648 ~ ~ ~ p=1.000 n=6
Memory used 3,347,471k (± 0.01%) 3,347,192k (± 0.01%) ~ 3,346,806k 3,347,626k p=0.230 n=6
Parse Time 17.98s (± 0.33%) 18.00s (± 0.52%) ~ 17.86s 18.10s p=0.748 n=6
Bind Time 5.64s (± 0.21%) 5.62s (± 0.33%) -0.02s (- 0.38%) 5.59s 5.64s p=0.048 n=6
Check Time 110.06s (± 2.08%) 111.15s (± 1.43%) ~ 108.19s 112.52s p=0.471 n=6
Emit Time 33.64s (± 7.78%) 34.82s (± 2.57%) ~ 33.48s 35.77s p=0.689 n=6
Total Time 167.33s (± 1.33%) 169.59s (± 0.91%) ~ 166.90s 171.24s p=0.128 n=6
webpack - node (v18.15.0, x64)
Errors 0 0 ~ ~ ~ p=1.000 n=6
Symbols 292,552 292,528 -24 (- 0.01%) ~ ~ p=0.001 n=6
Types 119,125 119,113 -12 (- 0.01%) ~ ~ p=0.001 n=6
Memory used 446,075k (± 0.03%) 446,096k (± 0.02%) ~ 446,017k 446,232k p=0.936 n=6
Parse Time 4.10s (± 0.89%) 4.08s (± 1.13%) ~ 4.04s 4.17s p=0.422 n=6
Bind Time 1.79s (± 1.64%) 1.77s (± 0.97%) ~ 1.75s 1.79s p=0.167 n=6
Check Time 18.77s (± 0.62%) 18.86s (± 0.59%) ~ 18.74s 19.00s p=0.173 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 24.67s (± 0.65%) 24.72s (± 0.48%) ~ 24.60s 24.88s p=0.688 n=6
xstate-main - node (v18.15.0, x64)
Errors 5 5 ~ ~ ~ p=1.000 n=6
Symbols 555,375 555,375 ~ ~ ~ p=1.000 n=6
Types 186,146 186,146 ~ ~ ~ p=1.000 n=6
Memory used 494,533k (± 0.01%) 494,510k (± 0.01%) ~ 494,456k 494,543k p=0.810 n=6
Parse Time 3.41s (± 0.93%) 3.42s (± 0.92%) ~ 3.37s 3.46s p=0.872 n=6
Bind Time 1.19s (± 1.06%) 1.19s (± 1.06%) ~ 1.18s 1.21s p=1.000 n=6
Check Time 19.61s (± 0.47%) 19.55s (± 0.28%) ~ 19.49s 19.65s p=0.296 n=6
Emit Time 0.00s 0.00s ~ ~ ~ p=1.000 n=6
Total Time 24.21s (± 0.42%) 24.16s (± 0.36%) ~ 24.04s 24.30s p=0.471 n=6
System info unknown
Hosts
  • node (v18.15.0, x64)
Scenarios
  • Compiler-Unions - node (v18.15.0, x64)
  • angular-1 - node (v18.15.0, x64)
  • mui-docs - node (v18.15.0, x64)
  • self-build-src - node (v18.15.0, x64)
  • self-build-src-public-api - node (v18.15.0, x64)
  • self-compiler - node (v18.15.0, x64)
  • ts-pre-modules - node (v18.15.0, x64)
  • vscode - node (v18.15.0, x64)
  • webpack - node (v18.15.0, x64)
  • xstate-main - node (v18.15.0, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@typescript-bot
Copy link
Collaborator

@sandersn Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61086/merge:

Everything looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sandersn sandersn

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
PR Backlog
Status: Not started
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandersn @typescript-bot