Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override MessageEventTarget's events' this-parameter type #1882

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sandersn
Copy link
Member

This adds the ability to override the this parameter of a type's event handlers, which I need for MessageEventTarget to avoid breaking code.
Technically, I believe this: this is correct for all event handlers, but it's expensive to compile and confusing to understand so I'd prefer to use it only when needed.

I don't know if this is the right way to do this in the generator code. Corrections welcome.

Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

@saschanaz
Copy link
Contributor

Probably better to autodetect whether there's inheritance/mixin relationship and use this automatically in such case, wdyt? (In that case anything related to HTMLElement should be excluded for now or otherwise all the HTML event handlers would get this.)

@saschanaz
Copy link
Contributor

But in case this is urgent I think this is fine too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants