Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running "test" in a clean repo #1873

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

kraenhansen
Copy link
Contributor

I did a checkout of the repo, ran npm install and npm test and got:

deploy/deployChangedPackages.js:12:39 - error TS2307: Cannot find module '../lib/changelog.js' or its corresponding type declarations.

12 import { generateChangelogFrom } from "../lib/changelog.js";
                                         ~~~~~~~~~~~~~~~~~~~~~

deploy/versionChangelog.js:5:52 - error TS2307: Cannot find module '../lib/changelog.js' or its corresponding type declarations.

5 import { gitShowFile, generateChangelogFrom } from "../lib/changelog.js";
                                                     ~~~~~~~~~~~~~~~~~~~~~

This is because eslint runs on files that import from files which has not been built initially, turning these two around (building before linting) seems like a harmless fix.

@sandersn sandersn closed this Jan 31, 2025
@sandersn sandersn reopened this Jan 31, 2025
@sandersn
Copy link
Member

I'm not sure why the codeowners merging task is failing. I think it may be failing for anybody that isn't in MS, or saschanaz.

@sandersn sandersn merged commit d112b8d into microsoft:main Jan 31, 2025
7 of 8 checks passed
@kraenhansen kraenhansen deleted the fix-clean-test branch January 31, 2025 17:50
@saschanaz
Copy link
Contributor

I'm not sure why the codeowners merging task is failing. I think it may be failing for anybody that isn't in MS, or saschanaz.

Per the error message it's failing for any bodyless message 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants