Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type Canvas.toBlob/toDataURL quality argument as number #1862

Conversation

lionel-rowe
Copy link
Contributor

Fixes #1861

Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

Copy link
Contributor

@saschanaz saschanaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with nits:

inputfiles/overridingTypes.jsonc Outdated Show resolved Hide resolved
inputfiles/overridingTypes.jsonc Outdated Show resolved Hide resolved
@saschanaz
Copy link
Contributor

LGTM

@github-actions github-actions bot merged commit 7e248ca into microsoft:main Dec 12, 2024
5 checks passed
Copy link
Contributor

Merging because @saschanaz is a code-owner of all the changes - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants