[Settings > PT Run] Plugin manager: Add plugin version and website

[htcfreek]

Summary of the Pull Request

This PR implements a website link and the plugin version into the plugin metadata line visible in PT Run settings.

If the website uri in the plugin.json is badly formatted the link is not available in settings ui. This because we use a fallback uri in this case is to prevent a page crash.

Sample screenshot with a third-party plugin

PR Checklist

• Closes: [Run][Plugin Manager] UI: Clickable author name to open plugin website #9921 , [Settings > PT Run > Plugins] Show version number #33846
• Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
• Tests: Added/updated and all pass
• Localization: All end user facing strings can be localized
• Dev docs: Added/updated
• New binaries: Added on the required places
  • JSON for signing for new binaries
  • WXS for installer for new binaries and localization folder
  • YML for CI pipeline for new test projects
  • YML for signed pipeline
• Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Open tasks

• Get plugin metadata from PT Run into Settings app
  • Get version from assembly file
  • Update ViewModels
  • Implement ViewModel bindings into XAML code
• Improve the XAML code for the items separating dot. (Optional.)
• Add template selector to switch between layout with and without website (In case the website uri is not well formed.)
• Add handling off invalid uri strings.
• Update plugin metadata in PowerToys repository to have the correct website in the json files.
• Update screenshot.

Validation Steps Performed

Manual tested with default plugins and different website uri strings.

[htcfreek]

@davidegiacometti
Currently I using the Product version and I saw some third-party plugins that have a strange formatted product version. Should we better use the file version instead? What do you think?

Example:

[crutkas]

Nice!

[davidegiacometti]

@htcfreek nice work! 😃

Yeah, I think we should use file version since .NET 8 introduced a breaking change on how revision is handled in product version: https://learn.microsoft.com/en-us/dotnet/core/compatibility/sdk/8.0/source-link

[htcfreek]

@davidegiacometti
Would be great if you can take a look. I am not 100% sure but it seems that the page is a bit slow now.

[davidegiacometti]

Hi @htcfreek
I have tested it and it's working well! I left some comment, let me know what you think.

I haven't noticed any performance drop compared to 0.87 but I am on a new hardware and this could make a difference.

Personal preference and for consistency with the OS I will replace the dot separator with a vertical one.

Windows 11 settings

[htcfreek]

Personal preference and for consistency with the OS I will replace the dot separator with a vertical one.

@davidegiacometti
We can switch. I decided the current layout based on three things:

1. The discussion and my question in the issue.
2. The metadata control in the Toolkit has the same layout.
3. I think the dot looks better.

[davidegiacometti]

Personal preference and for consistency with the OS I will replace the dot separator with a vertical one.

@davidegiacometti We can switch. I decided the current layout based on three things:

1. The discussion and my question in the issue.
2. The metadata control in the Toolkit has the same layout.
3. I think the dot looks better.

I am fine with both. Just wanted to mention it because I like consistency with the OS.

[htcfreek]

@niels9001, @davidegiacometti
Suggestion:

• Remove template an ViewModel code.
• On invalid uri we fallback to https://aka.ms/PowerToys and hide the hyperlink button.
• I will keep my own code for all the layout stuff because I like it and I like to show the tool tip to show users what link they open. ;-)
• We switch to Win11 separator style.

I will try to do the changes within the next days.

[htcfreek]

@niels9001 , @davidegiacometti
I have implemented the requested changes:

I also tried the MetadataControl form the Toolkit. But I think it isn't an option because we get complexity in the ViewModel / csharp code for implementing a command interface and loose style flexibility.

[davidegiacometti]

Thanks for addressing the feedback. Looking so much cleaner!
I have tested it again and it's working well, I also didn't experience any performance regression.

Approved! ✅

[htcfreek]

@niels9001
Can you please approve and unblock the PR. Thank you.

[niels9001]

Suggested change

	Spacing="5">
	Spacing="4">

[htcfreek]

Any specific reason for this change? For me 4 feels to less and 6 feels to much. I like to keep 5.

(With 4 it looks more like a text character than a separator.)