add '0x' handling for divide by 0 scenarios #36390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaimecbernardo
added
the
Needs-Review
jaimecbernardo
approved these changes
Jan 2, 2025
|
@plante-msft @jaimecbernardo Won't this crash now on |
|
Plus, checking division by zero with regex seems like a very silly way to do things, since it won't catch things like |
|
It will not crash, just show a different NaN (Not a Number) or other error instead. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Closes #36032. Adds divide by zero handling for hex numbers in the calculator plugin.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed
Tested that reported scenario is fixed, as well as additional equations.