Skip to content

Commit

Permalink
[PTRun][Calculator]Handle hexadecimal numbers to not return divide by…
Browse files Browse the repository at this point in the history
… 0 error (#36390)

* add '0x' handling for divide by 0 scenarios

* fix comment on division by 0 check

---------

Co-authored-by: Connor Plante <[email protected]>
  • Loading branch information
plante-msft and Connor Plante authored Jan 2, 2025
1 parent a720dd5 commit 2ba5fb7
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ public CalculateResult Interpret(string input, CultureInfo cultureInfo, out stri
}

// check for division by zero
// We check if the string contains a slash followed by space (optional) and zero. Whereas the zero must not followed by dot or comma as this indicates a number with decimal digits. The zero must also not be followed by other digits.
if (new Regex("\\/\\s*0(?![,\\.0-9])").Match(input).Success)
// We check if the string contains a slash followed by space (optional) and zero. Whereas the zero must not be followed by a dot, comma, or 'x'/'X' as these indicate a number with decimal digits or a hexadecimal value respectively. The zero must also not be followed by other digits.
if (new Regex("\\/\\s*0(?![,\\.0-9xX])").Match(input).Success)
{
error = Properties.Resources.wox_plugin_calculator_division_by_zero;
return default;
Expand Down

0 comments on commit 2ba5fb7

Please sign in to comment.