Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to build as shared lib #575

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Conversation

bmarques1995
Copy link
Contributor

@bmarques1995 bmarques1995 commented Feb 1, 2025

Uses BUILD_SHARED_LIBS standard CMake option to build as a DLL/so vs. a static C++ library.

@walbourn walbourn self-assigned this Feb 3, 2025
@walbourn walbourn added the cmake Related to CMake build label Feb 3, 2025
@walbourn
Copy link
Member

walbourn commented Feb 3, 2025

Thanks for the contribution. I have some follow-up changes here to add VERSIONINFO to the produced DLL, and a few minor whitespace changes. I also want to make sure there's coverage for this scenario so I'll add jobs to some GitHub Actions to make sure this works long-term.

I also should look at DirectXMesh and UVAtlas for the same scenario. It still doesn't make any sense to me to add this to DirectX Tool Kit at this time.

@walbourn walbourn merged commit 5855f74 into microsoft:main Feb 3, 2025
81 checks passed
@walbourn walbourn linked an issue Feb 11, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake Related to CMake build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for build DirectXTex toolkit as shared libs (.dll)
2 participants