--ignore-mips does not apply to array textures #567
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--ignore-mips
flag add in #484 is intended as a 'header hack' to treats the mipLevel as if it were 1 in DDS files. This is a workaround for some corrupt files. This doesn't work on cubemaps, arrays, or cubemap arrays because of how miplevels are laid out in those files.This change just makes
--ignore-mips
only work on arraySize=1 textures since modifying the mipLevel count is not correct for array textures with mips. For array textures/cubemaps, the flag is ignored.