Fix exporting R8 files as PNG using libpng #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an incorrect stride value for R8 images being exported to PNG on the experimental libpng SaveToPNGFile implementation.
|
@luncliff Do you agree with this fix? |
When testing this I found that GetMetadataFromFile wasn't fully initializing the metadata struct.
|
I add a formal test for this code, and verified this is the right fix. |
luncliff
approved these changes
Sep 3, 2024
R8_UNORM shouldn't use TEX_ALPHA_MODE flags.
added error since interlacing fails
Trim whitespace
|
The CLA was triggered due to my edits. @microsoft-github-policy-service agree company="Microsoft" |
|
Updating test suite to cover this code explicitly walbourn/directxtextest#46 |
walbourn
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an incorrect stride value for R8 images being exported to PNG on the experimental libpng SaveToPNGFile implementation.
Also updated to make it clear interlaced images are not supported.