Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xbox auxiliary EncodeDDSHeader helper exposed as public function #497

Merged
merged 10 commits into from
Aug 19, 2024
Merged

Xbox auxiliary EncodeDDSHeader helper exposed as public function #497

merged 10 commits into from
Aug 19, 2024

Conversation

walbourn
Copy link
Member

@walbourn walbourn commented Aug 15, 2024 •
edited
Loading

This exposes the Xbox::EncodeDDSHeader helper function as was done a few years back for the standard DirectX::EncodeDDSHeader helper in #266.

Also moves Xbox extension structures to dds.h

Includes some minor CMake updates required from testing and some minor code review.

@walbourn walbourn added the xbox Related to Xbox One and/or Xbox Series X|S label Aug 15, 2024
@walbourn walbourn self-assigned this Aug 15, 2024
@walbourn walbourn linked an issue Aug 15, 2024 that may be closed by this pull request
Expose EncodeDDSHeader from DirectXTexXboxDDS.cpp #496
Closed
@walbourn walbourn requested a review from shawnhar August 16, 2024 18:19
@walbourn
Copy link
Member Author

walbourn/directxtextest#44

@walbourn walbourn merged commit 1c47191 into main Aug 19, 2024
72 of 83 checks passed
@walbourn walbourn deleted the xboxheadersfunc branch August 19, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scm-xbox scm-xbox scm-xbox approved these changes

@Andrew-Farrier Andrew-Farrier Awaiting requested review from Andrew-Farrier

@shawnhar shawnhar Awaiting requested review from shawnhar

Assignees

@walbourn walbourn

Labels
xbox Related to Xbox One and/or Xbox Series X|S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose EncodeDDSHeader from DirectXTexXboxDDS.cpp
2 participants
@walbourn @scm-xbox