Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty list access in raft.h #6763

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Fix empty list access in raft.h #6763

merged 2 commits into from
Jan 16, 2025

Conversation

maxtropets
Copy link
Collaborator

@maxtropets maxtropets commented Jan 15, 2025 •
edited
Loading

Found with hardening=debug (#6720)

...
...

35:    | startup                        | /usr/bin/../include/c++/v1/list:797: assertion !empty() failed: list::back called on empty list <br>  |
35:
35:    | reconfig_01_el2_12             | /usr/bin/../include/c++/v1/list:797: assertion !empty() failed: list::back called on empty list <br>  |
35:
35:    | reconfig_01_el0_23             | /usr/bin/../include/c++/v1/list:797: assertion !empty() failed: list::back called on empty list <br>  |
35:
35:    | election_while_reconfiguration | /usr/bin/../include/c++/v1/list:797: assertion !empty() failed: list::back called on empty list <br>  |
35:
35:    | retire_one                     | /usr/bin/../include/c++/v1/list:797: assertion !empty() failed: list::back called on empty list <br>  |
35:
35:    | reconnect                      | /usr/bin/../include/c++/v1/list:797: assertion !empty() failed: list::back called on empty list <br>  |

...
...

@maxtropets maxtropets self-assigned this Jan 15, 2025
@maxtropets maxtropets added run-long-test Run Long Test job run-long-verification Run Long Verification jobs labels Jan 15, 2025
@achamayou achamayou marked this pull request as ready for review January 16, 2025 09:31
@achamayou achamayou requested a review from a team as a code owner January 16, 2025 09:31
@achamayou achamayou added this pull request to the merge queue Jan 16, 2025
Merged via the queue into microsoft:main with commit b988221 Jan 16, 2025
22 of 23 checks passed
@achamayou achamayou deleted the f/raft-empty-list-deref branch January 16, 2025 10:00
@achamayou achamayou mentioned this pull request Jan 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyashton eddyashton eddyashton approved these changes

@achamayou achamayou achamayou approved these changes

Assignees

@maxtropets maxtropets

Labels
run-long-test Run Long Test job run-long-verification Run Long Verification jobs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxtropets @achamayou @eddyashton