Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HeaderAcceptField comp #6762

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

maxtropets
Copy link
Collaborator

Found with bound checking enabled on Azure Linux (#6720)

27: /usr/bin/../include/c++/v1/__debug_utils/strict_weak_ordering_check.h:50: assertion !__comp(*(__first + __a), *(__first + __b)) failed: Your comparator is not a valid strict-weak ordering

For instance, for a = "*/subtype/1.0" and b = "*/another/1.0" we get a < b == b < a == true, which doesn't satisfy the operator<() requirement.

Same applied for subtype comparison.

Changed the comparator function to only compare as less for a wildcard type pair if only one of the two types is a wildcard.

@maxtropets maxtropets requested a review from a team as a code owner January 15, 2025 19:03
@maxtropets maxtropets self-assigned this Jan 15, 2025
@maxtropets maxtropets added the run-long-test Run Long Test job label Jan 15, 2025
@achamayou achamayou added this pull request to the merge queue Jan 17, 2025
Merged via the queue into microsoft:main with commit be08553 Jan 17, 2025
17 checks passed
@achamayou achamayou deleted the f/http-accept-field-comparator branch January 17, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-long-test Run Long Test job
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants