Add az-dcap-client back to main for now, to enable LTS-compatible base images #6742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
eddyashton
approved these changes
Jan 8, 2025
achamayou
deleted the
add_dcap_client_library_to_base_image_for_lts_tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking a step back after #6737 and #6739. We have been cutting CI images (
build/YYYY-MM-DD) fromrelease/5.xso as to get enough SGX attestation-verification dependencies to run the LTS compatibility tests in CI.Local tests suggest that adding
az-dcap-clientis sufficient to start 5.x-era nodes (who link oehost), and is likely the smallest delta we can apply to be able to cut CI images from main. This in turn will let us make changes like #6739, which cannot be backported to 5.x without substantial associated changes and risk.