Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for @MeterTag annotation on method level #5827

Conversation

MarinaMoiseenko
Copy link
Contributor

Fixes #3058

re-created pr with new branch, as failed to rebase initial one

Copy link
Member

@shakuzen shakuzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I left some minor review comments we can probably handle as polish when merging.

@shakuzen shakuzen changed the title Added support of @MeterTag annotation on method level Added support for @MeterTag annotation on method level Feb 5, 2025
@shakuzen shakuzen force-pushed the create-tags-based-on-method-result-2 branch from 0caa68f to e02515e Compare February 12, 2025 07:09
Adds nullability annotations, JavaDocs, and renames things for clarity.
@shakuzen shakuzen merged commit c53a182 into micrometer-metrics:main Feb 12, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow TimedAspect/CountedAspect to create tags based on method result
2 participants