Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure dependencies are correctly classified #2328

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Ensure dependencies are correctly classified #2328

merged 3 commits into from
Jan 28, 2025

Conversation

pkalita-lbl
Copy link
Collaborator

@pkalita-lbl pkalita-lbl commented Jan 28, 2025 •
edited
Loading

This is related to the error I mentioned here.

Currently the dependency specifications in this project are all out of sorts:

  • Regular dependencies declared as dev dependencies
  • Dev dependencies declared as regular dependencies
  • Transitive dependencies used without being declared

These changes:

  • Fix the classification of existing dependencies
  • Add missing dependency declarations
  • Add deptry checking to prevent backsliding into this situation again

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 28, 2025 •
edited
Loading

PR Preview Action v1.6.0

🚀 View preview at
https://microbiomedata.github.io/nmdc-schema/pr-preview/pr-2328/

Built to branch gh-pages at 2025-01-28 21:35 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@pkalita-lbl pkalita-lbl marked this pull request as ready for review January 28, 2025 18:41
@pkalita-lbl pkalita-lbl requested review from turbomam and sujaypatil96 and removed request for turbomam January 28, 2025 18:42
@pkalita-lbl pkalita-lbl mentioned this pull request Jan 28, 2025
Merged
turbomam
turbomam approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@turbomam turbomam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you very much

@pkalita-lbl pkalita-lbl merged commit 9c66367 into main Jan 28, 2025
3 checks passed
@pkalita-lbl pkalita-lbl deleted the fix-project-dependencies branch January 28, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbomam turbomam turbomam approved these changes

@sujaypatil96 sujaypatil96 Awaiting requested review from sujaypatil96

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pkalita-lbl @turbomam