Add slot and enumeration to MetaproteomicsAnalysis class and implement migrator.
#2276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
eecavanna
reviewed
Nov 27, 2024
eecavanna
approved these changes
Nov 27, 2024
|
FYI: The deadline for merging this into |
|
I've incorporated edits from @SamuelPurvine regarding PV descriptions. @turbomam - please review this before Wednesday, December 4, it's important for the new Metaproteomics workflow to have this enumeration in place and we want to use that workflow to process new data for the renewal. |
turbomam
reviewed
Dec 4, 2024
| enums: | ||
| MetaproteomicsAnalysisCategoryEnum: | ||
| description: The category of metaproteomics analysis being performed. | ||
| permissible_values: |
There was a problem hiding this comment.
the PV descriptions are more value-added than the MetaproteomicsAnalysisCategoryEnum description!
turbomam
reviewed
Dec 4, 2024
| @@ -0,0 +1,13 @@ | |||
| # This example is invalid because it is missing the required slot `metaproteomics_analysis_category` and that slot is required by the schema. | |||
turbomam
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR will close #2256.
It will
metaproteomics_analysis_categoryto theMetaproteomicsAnalysisclassmetaproteomics_analysis_categoryto the schema, with a range ofMetaproteomicsAnalysisCategoryEnumMetaproteomicsAnalysisCategoryEnumto the schemametaproteomics_analysis_categorymetaproteomics_analysis_categoryMetaproteomicsAnalysisrecords withmetaproteomics_analysis_categoryvalue ofmatched_metagenome. Note that this logic is used because all current data use amatched_metagenomeand we're adding this enumeration in preparation for the second category of analysis.I have tested the migrator locally with no issues.