Add pattern constraint to in_manifest on DataObject
#2275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
eecavanna
reviewed
Nov 25, 2024
aclum
requested review from
eecavanna,
kheal,
sierra-moxon,
turbomam and
bmeluch
|
cc @mbthornton-lbl FYI |
aclum
changed the title
kheal
reviewed
Nov 26, 2024
Move pattern for in_manifest to global def.
kheal
approved these changes
Nov 26, 2024
bmeluch
approved these changes
Nov 26, 2024
eecavanna
reviewed
Nov 26, 2024
eecavanna
changed the title
in_manifest on DataObject
Co-authored-by: eecavanna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a pattern constraint to in_manifest. Without this it is possible to malform the id mention such that it causes voliations for refscan and for linkml_runtime/utils/metamodelcore.py in nmdc_automation.
Fixes #2274
Related to microbiomedata/issues#948