Migrations: Implement adapter method that deletes field from all documents in collection #2263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Merging without additional review (with respect to the self-review I did just now) so that the reviewers can focus on the third PR (the one that impacts the outside world): #2265 |
eecavanna
deleted the
2261-migrations-implement-adapter-method-delete_field_from_each_document
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this branch, I implemented an adapter method named
remove_field_from_each_document, which migrator authors can use to delete a given field from every document in a given collection.Previously, migrator authors could do this by iterating over documents in Python. This new adapter method delegates the iteration to MongoDB.
Fixes #2261