Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrations: Implement adapter method that copies values between two fields in all documents in a collection #2262

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions nmdc_schema/migrators/adapters/adapter_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -126,3 +126,16 @@ def do_for_each_document(
to facilitate iterating over all documents in a collection without actually modifying them.
"""
pass

@abstractmethod
def copy_value_from_field_to_field_in_each_document(
self,
collection_name: str,
source_field_name: str,
destination_field_name: str,
) -> None:
r"""
For each document in the collection that has the source field, copy the value of the source field
into the destination field, creating the destination field if it doesn't already exist.
"""
pass
39 changes: 39 additions & 0 deletions nmdc_schema/migrators/adapters/dictionary_adapter.py
Original file line number Diff line number Diff line change
Expand Up @@ -364,3 +364,42 @@ def do_for_each_document(
if collection_name in self._db:
for document in self._db[collection_name]:
action(document)

def copy_value_from_field_to_field_in_each_document(
self,
collection_name: str,
source_field_name: str,
destination_field_name: str,
) -> None:
r"""
For each document in the collection that has the source field, copy the value of the source field
into the destination field, creating the destination field if it doesn't already exist.

>>> database = {
... "thing_set": [
... {"id": "1", "color": "blue"},
... {"id": "2", "color": None},
... {"id": "3"},
... {"id": "4", "color": "blue", "hue": "yellow"},
... {"id": "5", "color": "blue", "hue": None},
... ]
... }
>>> da = DictionaryAdapter(database)
>>> da.copy_value_from_field_to_field_in_each_document("thing_set", "color", "hue")
>>> database["thing_set"][0] # source field exists and is not empty
{'id': '1', 'color': 'blue', 'hue': 'blue'}
>>> database["thing_set"][1] # source field is empty
{'id': '2', 'color': None, 'hue': None}
>>> database["thing_set"][2] # source field does not exist
{'id': '3'}
>>> database["thing_set"][3] # destination field exists and is not empty
{'id': '4', 'color': 'blue', 'hue': 'blue'}
>>> database["thing_set"][4] # destination field exists and is empty
{'id': '5', 'color': 'blue', 'hue': 'blue'}
"""

# Iterate over every document in the collection, if the collection exists.
if collection_name in self._db:
for document in self._db[collection_name]:
if source_field_name in document:
document[destination_field_name] = document[source_field_name]
24 changes: 24 additions & 0 deletions nmdc_schema/migrators/adapters/mongo_adapter.py
Original file line number Diff line number Diff line change
Expand Up @@ -212,3 +212,27 @@ def do_for_each_document(
collection = self._db.get_collection(name=collection_name)
for document in collection.find():
action(document)

def copy_value_from_field_to_field_in_each_document(
self,
collection_name: str,
source_field_name: str,
destination_field_name: str,
) -> None:
r"""
For each document in the collection that has the source field, copy the value of the source field
into the destination field, creating the destination field if it doesn't already exist.

References:
- https://www.mongodb.com/docs/manual/reference/method/db.collection.updateMany
- https://www.mongodb.com/docs/manual/reference/operator/update/set/
- https://pymongo.readthedocs.io/en/stable/api/pymongo/collection.html#pymongo.collection.Collection.update_many
"""

# Update every document in the collection, if the collection exists.
if collection_name in self._db.list_collection_names():
collection = self._db.get_collection(name=collection_name)
collection.update_many(
{source_field_name: {"$exists": True}},
[{"$set": {destination_field_name: f"${source_field_name}"}}]
)
32 changes: 30 additions & 2 deletions nmdc_schema/migrators/adapters/test_mongo_adapter.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class TestMongoAdapter(unittest.TestCase):
You can start up a containerized MongoDB server like this:
$ docker run --rm --detach --name mongo-test-nmdc-schema -p 27017:27017 mongo

One that's running, other containers will be able to access it via:
Once that's running, other containers will be able to access it via:
- host.docker.internal:27017

You can run these tests like this:
Expand Down Expand Up @@ -263,7 +263,7 @@ def test_set_field_of_each_document(self):
adapter.set_field_of_each_document(collection_name, "x", "new")

# Validate result:
collection = self.db[collection_name]
collection = self.db.get_collection(collection_name)
assert collection.count_documents({"x": "original"}) == 0
assert collection.count_documents({"x": {"$exists": False}}) == 0
assert collection.count_documents({"x": None}) == 0
Expand Down Expand Up @@ -310,6 +310,34 @@ def append_x_to_sequence(doc: dict) -> None:
# Clean up:
delattr(self, "_characters")

def test_copy_value_from_field_to_field_in_each_document(self):
# Set up:
collection_name = "my_collection"
document_1 = dict(_id=1, id=1, x="a")
document_2 = dict(_id=2, id=2, x=None)
document_3 = dict(_id=3, id=3)
document_4 = dict(_id=4, id=4, x="a", y="b")
document_5 = dict(_id=5, id=5, x="a", y=None)
self.db.create_collection(collection_name)
self.db.get_collection(collection_name).insert_many(
[document_1, document_2, document_3, document_4, document_5]
)

# Invoke function-under-test:
adapter = MongoAdapter(database=self.db)
adapter.copy_value_from_field_to_field_in_each_document(
collection_name, "x", "y"
)

# Validate result:
collection = self.db.get_collection(collection_name)
assert collection.count_documents({}) == 5
assert collection.count_documents({"_id": 1, "id": 1, "x": "a", "y": "a"}) == 1
assert collection.count_documents({"_id": 2, "id": 2, "x": None, "y": None}) == 1
assert collection.count_documents({"_id": 3, "id": 3}) == 1
assert collection.count_documents({"_id": 4, "id": 4, "x": "a", "y": "a"}) == 1
assert collection.count_documents({"_id": 5, "id": 5, "x": "a", "y": "a"}) == 1

def test_callbacks(self):
# Set up:
collection_name = "my_collection"
Expand Down
Loading