Skip to content

Commit

Permalink
#1443 remove Instrument and InstrumetnValue comments
Browse files Browse the repository at this point in the history
  • Loading branch information
turbomam committed Nov 29, 2023
1 parent d159329 commit 3b38be9
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 27 deletions.
23 changes: 0 additions & 23 deletions src/schema/core.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -212,14 +212,6 @@ classes:
type:
description: An optional string that specified the type of object.

# InstrumentValue:
# is_a: AttributeValue
# slots:
# - has_unit
# - has_numeric_value
# - instrument_name


QuantityValue:
is_a: AttributeValue
description: A simple quantity, e.g. 2cm
Expand Down Expand Up @@ -301,21 +293,6 @@ classes:
- total_bases
- type

# Instrument:
# is_a: NamedThing
# aliases:
# - device
# description: >-
# A material entity that is designed to perform a function in a scientific investigation, but is not a reagent[OBI].
# exact_mappings:
# - OBI:0000485
# slot_usage:
# id:
# required: true
# structured_pattern:
# syntax: "{id_nmdc_prefix}:inst-{id_shoulder}-{id_blade}{id_version}{id_locus}"
# interpolated: true

MetaboliteQuantification:
description: This is used to link a metabolomics analysis workflow to a specific metabolite
slots:
Expand Down
2 changes: 0 additions & 2 deletions src/schema/prov.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,5 @@ slots:

used:
domain: Activity
# some Instrument slot usages, but those require a CURIE, not a bare string
# this is being used more like instrument_name
mappings:
- prov:used
2 changes: 0 additions & 2 deletions src/schema/workflow_execution_activity.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,6 @@ classes:
- has_peptide_quantifications
slot_usage:
used:
# range: Instrument
description: The instrument used to collect the data used in the analysis
id:
required: true
Expand All @@ -309,7 +308,6 @@ classes:
slot_usage:
used:
range: string
# range: Instrument
description: The instrument used to collect the data used in the analysis
id:
required: true
Expand Down

0 comments on commit 3b38be9

Please sign in to comment.