Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ADR for env triad #881

Merged
merged 27 commits into from
Sep 19, 2024
Merged

add ADR for env triad #881

merged 27 commits into from
Sep 19, 2024

Conversation

@mslarae13 mslarae13 changed the title Draft: add ADR for env triad add ADR for env triad Aug 28, 2024
@mslarae13
Copy link
Contributor Author

@cmungall , maybe also try a bottom up approach, what maps to GOLD?

  • Mark, didn't use GOLD but did use a bottom up as anything that's currently present in mongo DB or is valid for mims-soil.

App needs to show the PVs that we select.

@ssarrafan
Copy link
Contributor

I think this can be closed but since there were multiple PR's I'll wait for @mslarae13 @turbomam to close this.

@eecavanna
Copy link
Contributor

eecavanna commented Sep 13, 2024

I read the first part of this ADR and left feedback on it. I think I may have been tagged as a reviewer by mistake as I am not familiar with the subject matter. I didn't read the second half of the ADR. I will un-tag myself as a reviewer. In case you do want me to review this ADR, you can re-add me.

@eecavanna
Copy link
Contributor

eecavanna commented Sep 13, 2024

Looks like I can't un-tag myself as a reviewer (maybe because I've already left feedback). Based on what I said in my previous comment, I don't plan on reviewing the remainder of this ADR unless someone confirms to me they want me to review it.

@mslarae13
Copy link
Contributor Author

I read the first part of this ADR and left feedback on it. I think I may have been tagged as a reviewer by mistake as I am not familiar with the subject matter. I didn't read the second half of the ADR. I will un-tag myself as a reviewer. In case you do want me to review this ADR, you can re-add me.

@eecavanna wasn't a mistake! I just appreciate your thorough review and corrections :)
No problem on just doing the first half.
Thank you!!

@mslarae13 mslarae13 merged commit 64399c8 into main Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
5 participants