Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add reference samples to divergence outputs #100

Merged
merged 6 commits into from
Jan 22, 2025
Merged

add reference samples to divergence outputs #100

merged 6 commits into from
Jan 22, 2025

Conversation

Daenarys8
Copy link
Contributor

TuomasBorman
TuomasBorman requested changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@TuomasBorman TuomasBorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run the code? It seems not to work. Instead of adding reference samples to df, it adds the name of reference sample column. Instead, the reference samples are stored in x[[reference]].

R/getBaselineDivergence.R Outdated Show resolved Hide resolved
R/getBaselineDivergence.R Outdated Show resolved Hide resolved
R/getBaselineDivergence.R Outdated Show resolved Hide resolved
R/getBaselineDivergence.R Outdated Show resolved Hide resolved
R/getBaselineDivergence.R Outdated Show resolved Hide resolved
tests/testthat/test-getStepwiseDivergence.R Outdated Show resolved Hide resolved
vignettes/miaTime.Rmd Outdated Show resolved Hide resolved
vignettes/articles/minimalgut.Rmd Outdated Show resolved Hide resolved
R/getBaselineDivergence.R Outdated Show resolved Hide resolved
R/getBaselineDivergence.R Outdated Show resolved Hide resolved
Daenarys8 and others added 2 commits November 25, 2024 14:02
@TuomasBorman TuomasBorman self-requested a review December 16, 2024 13:05
@TuomasBorman TuomasBorman merged commit af7a0e0 into devel Jan 22, 2025
3 checks passed
@TuomasBorman TuomasBorman deleted the refsam branch January 22, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TuomasBorman TuomasBorman TuomasBorman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Daenarys8 @TuomasBorman