-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unlimited size of data sent #15
base: master
Are you sure you want to change the base?
Conversation
Thanks for the PR! Taking a look |
Code looks great! But I will have to test it once I get home this weekend before I can approve |
I was about to make a PR for this too 👍. I will run it against our implementation for testing (sizes >100k) |
thanks for testing @riffy! sorry I haven't gotten around to this one yet. It's a bigger feature than some of the other recent PRs so might take a bit of tweaking to get right |
very nice, i hope this comes soon |
So I didn't really got to testing. I tried changing the Basically I've either implemented it wrong or I found a case where this PR does not resolve the issue in total. @micaww sorry to push it back to you, but maybe you can test it? |
Try to install this from my branch (already compiled into dist):
I use it on production without issues. |
@ziggi tried it with the #nolimit branch as mentioned in the PR. But I will try with mypatches |
Hi @ziggi @micaww , I've ran some tests with the
The error was due to a timeout. I couldnt evaluate Server -> Browser quickly but I assume it's okay. Thank you ziggi for this PR. It's also a little bit faster than my implementation (~.5 second per 10k calls). Maybe update PR to the |
By default ragemp limited to 2^15 symbols for sending through events. This PR removes this limitation by splitting large data to smaller parts.