Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlimited size of data sent #15

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Unlimited size of data sent #15

wants to merge 3 commits into from

Conversation

ziggi
Copy link
Contributor

@ziggi ziggi commented Dec 19, 2019

By default ragemp limited to 2^15 symbols for sending through events. This PR removes this limitation by splitting large data to smaller parts.

@ziggi ziggi changed the title Nolimit Unlimited size of data sent Dec 19, 2019
@micaww
Copy link
Owner

micaww commented Dec 26, 2019

Thanks for the PR! Taking a look

@micaww
Copy link
Owner

micaww commented Dec 26, 2019

Code looks great! But I will have to test it once I get home this weekend before I can approve

@riffy
Copy link

riffy commented Jan 26, 2020

I was about to make a PR for this too 👍. I will run it against our implementation for testing (sizes >100k)

@micaww
Copy link
Owner

micaww commented Jan 26, 2020

thanks for testing @riffy! sorry I haven't gotten around to this one yet. It's a bigger feature than some of the other recent PRs so might take a bit of tweaking to get right

@TPDGhost
Copy link

very nice, i hope this comes soon

@riffy
Copy link

riffy commented Jan 30, 2020

So I didn't really got to testing. I tried changing the rage-rpc.min.js and implementing the files provided in src, but I didn't get it to work (maybe I'm just too stupid 😢 ) --> Callback Invoke Error #10 : Unexpected end of JSON string.

Basically I've either implemented it wrong or I found a case where this PR does not resolve the issue in total.

@micaww sorry to push it back to you, but maybe you can test it?

@ziggi
Copy link
Contributor Author

ziggi commented Jan 30, 2020

Try to install this from my branch (already compiled into dist):

npm install --save github:ziggi/rage-rpc#mypatches

I use it on production without issues.

@riffy
Copy link

riffy commented Jan 30, 2020

@ziggi tried it with the #nolimit branch as mentioned in the PR. But I will try with mypatches

@riffy
Copy link

riffy commented Feb 1, 2020

Hi @ziggi @micaww , I've ran some tests with the #mypatches branch and it works. Here is some data:

Server -> Client -> Server

Objectlength Calls Correct Wrong Errors
370 50000 50000 0 0
66392 50000 50000 0 0
187221 50000 49999 0 1

The error was due to a timeout.

I couldnt evaluate Server -> Browser quickly but I assume it's okay. Thank you ziggi for this PR. It's also a little bit faster than my implementation (~.5 second per 10k calls). Maybe update PR to the #mypatches branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants