Update ember cli and convert to DDAU

[stopdropandrew]

This pull upgrades to the latest Ember (fixes #121), and in the process switches to DDAU (fixes #120 and fixes #59).

[dgavey]

Thanks for this! Wasn't expecting this to come in. Obviously this will be a major breaking change for existing users. I'll need to mark it as such. I'll need to dig in here and explore this PR in depth first before I can pull it in.

[stopdropandrew]

Let me know if you have any questions. I tried to just forklift the addon with no changes other than moving to closure actions. Happy to help with whatever it needs to get this merged.

[tamzinblake]

This would be really helpful - I was about to look into filing an issue to upgrade ember-cli-babel because of a deprecation warning coming from ember-cli-version-checker, but this PR fixes that too.

[chadRoberge]

Really looking forward to this as well!

[boris-petrov]

@dgavey - is there any progress on this?

[dgavey]

Unfortunately no, I've taken a new job, and I really haven't found any extra time for working on this project currently. If someone want's to take it up to become a maintainer, I would be happy to add them.

[boris-petrov]

@stopdropandrew - perhaps you could create separate PRs (one for the first and second commits, one for the third commit and one for the DDAU stuff) which could be reviewed and merged independently (by @dgavey and the rest of us). The first two commits are the most urgent ones right now because of the deprecation warnings. The rest could follow later and with a major version bump because of the breaking changes. Does that sound reasonable?

[stopdropandrew]

It's been awhile since working on this, but as I recall I took that larger leap because there were new deprecation warnings introduced when upgrading ember-cli. But we can certainly split them up.

[boris-petrov]

@dgavey - could you take another look at this PR please? I've been using it in production for a couple of months now and seems stable.

@stopdropandrew - do you mind rebasing on master so the branch can be merged? And, if @dgavey requests so, perhaps split it into a couple of new PRs?

[viniciussbs]

Obviously this will be a major breaking change for existing users

@dgavey the breaking changes come from the DDAU changes? What about checking if the action attribute is a string or a function to decide how to call/trigger the action?

[boris-petrov]

@mharris717, @stopdropandrew, @dgavey - Ember 3.4 will deprecate sendAction and specifying actions without the action helper. This PR becomes mandatory at that point. Care to take another look? We used this branch in production for a while and there were no problems.

The breaking change can be "fixed" by incrementing the major version of the library. It's there for exactly that. :)

[dgavey]

I'll try to find time this week to at least get the addon upgraded to the latest Ember on a separate branch.

[boris-petrov]

@dgavey - Ember 3.4 is out with a million deprecation warnings. Please take another look at this PR - just copy-paste its changes into master - they do work fine. :)

There is also another deprecation warning about jQuery usages - there are issues about it here and here.

[dgavey]

Yes I will use this branch and create a new release off of it soon, sorry about the delay on this.

[dgavey]

Ok Merged, thanks for your patience. You should be able to use this with 0.5.0 I'm going to get it updated to the latest ember with another version bump hopefully shortly.

[jackiehluo]

Does anyone in this thread happen to know when there are two more instances of sendAction() in coordinator.js when it looks like this PR removes all the others? Is there any workaround for that? We're getting deprecation warnings in our app from it.

[jevanlingen]

@jackiehluo: If I read the code, the sendAction lines are still there to provide support for Ember < 1.13.

@Team: Since Ember 3.4 deprecates the sendAction, could the lines be either removed or skipped if a new Ember version is used?