refactor: perform dimensional analysis and numerical evaluation in same pass (WIP) #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes one recursive walk through the expression tree.
mgreminger
changed the title
…holder function Simplifies replace_placeholder_funcs function by removing a special case
Values needed for dimensional analysis are stored in the evaluation pass instead
Code generation still has issues
Use strings instead of BigInt for efficiency
Firefox is consistently timing out on this test
Still needs to be removed from JS code
rational exponents with large denominators causes very long calculation times.
Prevents losing exactness for symbolic results while speeding up numerical results
Add test for symbolic representation of small rationals
This allows functions like range that need to know the result of the calculation to set the correct dims. Range now works with inputs that have consistent units. New test added for this functionality.
Removed remaining unitless sub query code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable cases where dimensional analysis depends on results of evaluation pass (variable matrix size output, for example).