Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Python venv support #97

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

feat: Python venv support #97

wants to merge 16 commits into from

Conversation

Natoandro
Copy link
Contributor

  • New features:
    • use pattern on EnvBuilder for a re-usable set of setups;
    • Custom binary directories, static or dynamic, registered with env(...).binDir("<path>");
    • Idem for lib and C include directories (libDir, includeDir) (wip);
    • Python virtual environment (venv) support, based on the use pattern.

Migration notes

No breaking changes

  • The change comes with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

Copy link

coderabbitai bot commented Aug 15, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Natoandro Natoandro changed the title Python venv feat: Python venv support Aug 15, 2024
modules/envs/types.ts Outdated Show resolved Hide resolved
files/mod.ts Outdated Show resolved Hide resolved
library/py.ts Outdated Show resolved Hide resolved
library/py.ts Outdated Show resolved Hide resolved
files/mod.ts Outdated Show resolved Hide resolved
@Yohe-Am
Copy link
Contributor

Yohe-Am commented Aug 16, 2024

Can you try this on the Metatype repo before you merge it? In case it needs something more we didn't anticipate. Check how well it works in CI as well

@Natoandro Natoandro requested a review from Yohe-Am August 19, 2024 07:31
@Natoandro Natoandro marked this pull request as ready for review August 19, 2024 07:31
files/MergedEnvs.ts Outdated Show resolved Hide resolved
files/MergedEnvs.ts Outdated Show resolved Hide resolved
@Natoandro Natoandro force-pushed the python-venv branch 2 times, most recently from 59be295 to c464d14 Compare August 29, 2024 22:22
@Yohe-Am
Copy link
Contributor

Yohe-Am commented Oct 2, 2024

@Natoandro should I assist on this?

@zifeo
Copy link
Member

zifeo commented Oct 27, 2024

@Natoandro anything left to do here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants