Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tasks and lockfiles #28

Merged
merged 44 commits into from
Jan 9, 2024
Merged

feat: tasks and lockfiles #28

merged 44 commits into from
Jan 9, 2024

Conversation

Yohe-Am
Copy link
Contributor

@Yohe-Am Yohe-Am commented Dec 22, 2023

Describe your change

First crack at tasks.

Motivation and context

#10

Migration notes

  • The ghjk executable now looks for or generates a .ghjk directory next to ghjk.ts.
  • $GHJK_CONFIG has been renamed to $GHJKFILE
  • $GHJK_DIR meaning has been changed to point at the discovered .ghjk dir as opposed to the ghjk share dir.
  • ghjk.ts serialization might be skipped if the it's been determined that no important inputs have changed.
  • InstallConfig.version is now checked against the versions returned by the port's listAll implementation.
  • Resolved InstallConfig.version is now cached in the lockfile. For now, manually remove the lockfile to re-resolve everything.
  • install and download steps on a port are skipped if they'd previously successfully completed on the same InstallConfig.

Checklist

  • The change come with new or modified tests
  • Hard-to-understand functions have explanatory comments
  • End-user documentation is updated to reflect the change

@Yohe-Am Yohe-Am marked this pull request as ready for review December 28, 2023 03:32
Copy link
Member

@zifeo zifeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far

deps/common.ts Outdated Show resolved Hide resolved
ghjk.ts Outdated Show resolved Hide resolved
ghjk.ts Outdated Show resolved Hide resolved
ghjk.ts Show resolved Hide resolved
mod.ts Outdated Show resolved Hide resolved
modules/ports/db.ts Show resolved Hide resolved
@Yohe-Am Yohe-Am linked an issue Dec 29, 2023 that may be closed by this pull request
@Yohe-Am Yohe-Am mentioned this pull request Dec 29, 2023
30 tasks
@Yohe-Am Yohe-Am requested review from zifeo and Natoandro January 2, 2024 09:20
Copy link
Member

@zifeo zifeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion, otherwise lgtm

install/mod.ts Outdated Show resolved Hide resolved
Copy link
Member

@zifeo zifeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the new lock file :)

ghjk.ts Outdated Show resolved Hide resolved
@Yohe-Am Yohe-Am requested a review from zifeo January 9, 2024 00:06
Copy link
Member

@zifeo zifeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huge work!

@Yohe-Am Yohe-Am changed the title feat: tasks feat: tasks and lockfiles Jan 9, 2024
@Yohe-Am Yohe-Am merged commit 9c02081 into main Jan 9, 2024
13 checks passed
@Yohe-Am Yohe-Am deleted the feat/tasks-module branch January 9, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tasks module
2 participants