Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest less-rails #132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

veelenga
Copy link

@veelenga veelenga commented Jan 15, 2018

Thanks a lot for maintaining this gem.

We use it in one of our production apps which is running on rails 4.2. Upgrading to the latest ruby/rails offers us to upgrade less-rails which is a dependency on less-rails-bootstrap.

This PR is about to upgrade this gem to the latest available less-rails:

metaskills/less-rails@v2.8.0...v3.0.0

This addresses #131 and #130

I hope the PR is ok and you will be able to review/merge it ❤️

@veelenga veelenga force-pushed the fix/upgrade-less-rails branch 2 times, most recently from fcf2937 to 65c6049 Compare January 15, 2018 19:58
@veelenga veelenga changed the title Upgrade dependencies, newer ruby support Latest less-rails Jan 15, 2018
@veelenga veelenga force-pushed the fix/upgrade-less-rails branch 4 times, most recently from a06a5d0 to da4a549 Compare January 15, 2018 20:25
@veelenga veelenga force-pushed the fix/upgrade-less-rails branch from da4a549 to 7c479c2 Compare January 15, 2018 20:35
@denqxotl
Copy link

👍

1 similar comment
@ghost
Copy link

ghost commented Jan 16, 2018

👍

@Genkilabs
Copy link

Genkilabs commented Mar 12, 2018

@veelenga I took a look at the diff and it seems good to me.
Since it has still been several months with no motion on this I'm going to suggest your build at
gem 'less-rails-bootstrap', git: 'https://github.com/veelenga/less-rails-bootstrap', :ref => '7c479c2fdff500dc036c15364aa085332a73c642'
for our use on our staging, pending eventual production deployment (Ruby 2.4.2, Rails 5.1.5). If we encounter any issues I'll post them here.

Thank you for all your work on this issue. Hopefully it is merged into master soon!

UPDATE For those considering using this, the above ref has been running solidly on one of our our production servers at roughly 150req/min since April 8 2018 with no issues.

@NikoRoberts
Copy link

NikoRoberts commented May 6, 2018

Anything the community can do to help get this merged @metaskills ?

@a-m-zill
Copy link

Hi @metaskills!

Can this PR merged, please?!

It will be very helpfully for many projects.

Thx

@metaskills
Copy link
Owner

@simi Any thoughts?

@simi
Copy link
Collaborator

simi commented Jun 22, 2018

If I understand well, we're dropping Rails 3.x and moving to less-rails 3.x resulting into new major release will be needed here. Am I right?

@NikoRoberts
Copy link

Yes basically.
We’re now using the PRed fork in production with Rails 5.1.

@derekgottlieb
Copy link

Any chance to go ahead and get this merged and a new version pushed?

@aergonaut
Copy link

Hi @simi @metaskills. Pilling on here to wonder if there's any possibility for this PR to merged and a new version to be published. My team would really love to see a new version that permits less-rails 3!

@metaskills
Copy link
Owner

I won't have time to help with this but if I need to grant access to someone then I certainly will. @simi are you working this gem anymore?

@simi
Copy link
Collaborator

simi commented Sep 30, 2019

Sure, I'm still around. I'll take a look.

Repository owner deleted a comment from veelenga Dec 20, 2019
@ahwagner
Copy link

Seeing how this PR started 2 years ago my comment probably won't move the needle, but... any chance this can get merged in sometime soon @metaskills @simi?

@veelenga thanks for this fork.

@Genkilabs
Copy link

@metaskills Any chance on a tapping that juicy green merge button?

@metaskills
Copy link
Owner

Can @simi do that or someone a little more close to maintaining this project?

@simi
Copy link
Collaborator

simi commented May 12, 2020

ℹ️ I'm around, but since this PR does more than just updating less-rails dependency, I need to spend some time on that, split the changes, and test (also with latest rails).

🤔 If anyone around is able to open pull request updating just less-rails for now, it will be merged and released much faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants