-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest less-rails #132
base: master
Are you sure you want to change the base?
Latest less-rails #132
Conversation
fcf2937
to
65c6049
Compare
a06a5d0
to
da4a549
Compare
da4a549
to
7c479c2
Compare
👍 |
1 similar comment
👍 |
@veelenga I took a look at the diff and it seems good to me. Thank you for all your work on this issue. Hopefully it is merged into master soon! UPDATE For those considering using this, the above ref has been running solidly on one of our our production servers at roughly 150req/min since April 8 2018 with no issues. |
Anything the community can do to help get this merged @metaskills ? |
Hi @metaskills! Can this PR merged, please?! It will be very helpfully for many projects. Thx |
@simi Any thoughts? |
If I understand well, we're dropping Rails 3.x and moving to less-rails 3.x resulting into new major release will be needed here. Am I right? |
Yes basically. |
Any chance to go ahead and get this merged and a new version pushed? |
Hi @simi @metaskills. Pilling on here to wonder if there's any possibility for this PR to merged and a new version to be published. My team would really love to see a new version that permits less-rails 3! |
I won't have time to help with this but if I need to grant access to someone then I certainly will. @simi are you working this gem anymore? |
Sure, I'm still around. I'll take a look. |
Seeing how this PR started 2 years ago my comment probably won't move the needle, but... any chance this can get merged in sometime soon @metaskills @simi? @veelenga thanks for this fork. |
@metaskills Any chance on a tapping that juicy green merge button? |
Can @simi do that or someone a little more close to maintaining this project? |
ℹ️ I'm around, but since this PR does more than just updating less-rails dependency, I need to spend some time on that, split the changes, and test (also with latest rails). 🤔 If anyone around is able to open pull request updating just less-rails for now, it will be merged and released much faster. |
Thanks a lot for maintaining this gem.
We use it in one of our production apps which is running on rails 4.2. Upgrading to the latest ruby/rails offers us to upgrade less-rails which is a dependency on less-rails-bootstrap.
This PR is about to upgrade this gem to the latest available less-rails:
metaskills/less-rails@v2.8.0...v3.0.0
This addresses #131 and #130
I hope the PR is ok and you will be able to review/merge it ❤️