Coradoc integration #92
Conversation
* coradoc integration --------- Co-authored-by: Ronald Tse <[email protected]>
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
|
|
||
| u_before = unconstrained_before?(node) | ||
| u_after = unconstrained_after?(node) | ||
| u = !((!u_before || has_leading_whitespace) && (!u_after || has_trailing_whitespace)) |
| content | ||
| else | ||
| "#{content[/^\s*/]}_#{content.strip}_#{content[/\s*$/]}" | ||
| def to_coradoc(node, state = {}) |
There was a problem hiding this comment.
Assignment Branch Condition size for to_coradoc is too high. [<13, 29, 7> 32.54/15]
Cyclomatic complexity for to_coradoc is too high. [8/6]
Method has too many lines. [31/10]
Perceived complexity for to_coradoc is too high. [8/7]
| width = node['width'] | ||
| height = node['height'] | ||
| anchor = id ? "[[#{id}]]\n" : "" | ||
| def to_coradoc(node, _state = {}) |
There was a problem hiding this comment.
Assignment Branch Condition size for to_coradoc is too high. [<8, 15, 6> 18.03/15]
Cyclomatic complexity for to_coradoc is too high. [7/6]
Method has too many lines. [22/10]
Perceived complexity for to_coradoc is too high. [8/7]
| stem = stem.gsub(/\[/, "\\[").gsub(/\]/, "\\]").gsub(/\(\(([^\)]+)\)\)/, "(\\1)") unless stem.nil? | ||
| unless stem.nil? | ||
| stem = stem.gsub(/\[/, "\\[").gsub(/\]/, "\\]").gsub( | ||
| /\(\(([^\)]+)\)\)/, "(\\1)" |
There was a problem hiding this comment.
Redundant escape inside regexp literal
| else | ||
| nil | ||
| end | ||
| case node["style"] |
There was a problem hiding this comment.
Consider replacing case-when with a hash lookup.
| id = node['id'] | ||
| anchor = id ? "[[#{id}]]" : "" | ||
| colrowattr = colrow(node['colspan'], node['rowspan']) | ||
| def to_coradoc(node, state = {}) |
There was a problem hiding this comment.
Assignment Branch Condition size for to_coradoc is too high. [<18, 24, 8> 31.05/15]
Cyclomatic complexity for to_coradoc is too high. [7/6]
Method has too many lines. [20/10]
| then input.root | ||
| elsif input.is_a?(Nokogiri::XML::Node) | ||
| then input | ||
| def self.to_coradoc(input, options = {}) |
| is_expected.to include " link <<content,internal jumplinks>> with anchors " | ||
| } | ||
| it { | ||
| is_expected.to include " link <<content2>>internal jumplinks without anchors " |
| it { is_expected.to include ' link <<content2>>internal jumplinks without anchors ' } | ||
| it { is_expected.to include ' treat [[content]] as bookmarks ' } | ||
| it { | ||
| is_expected.to include " do not ignore link:foo.html[] anchor tags with no link text " |
|
|
||
| it { is_expected.to include 'There should be space before but not after the anchor ( http://foobar.com[stripped]).' } | ||
| it { | ||
| is_expected.to include "There should be space before but not after the anchor ( http://foobar.com[stripped])." |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| string | ||
| .gsub(/((?<=\s)[\*_]+)|[\*_]+(?=\s)/) { |n| n.chars.map { |char| subs[char] }.join } | ||
| .gsub(/((?<=\s)[\*_]+)|[\*_]+(?=\s)/) do |n| | ||
| n.chars.map do |char| | ||
| subs[char] | ||
| end.join | ||
| end |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data High
| stem = stem.gsub(/\[/, "\\[").gsub(/\]/, "\\]").gsub( | ||
| /\(\(([^\)]+)\)\)/, "(\\1)" | ||
| ) |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data High
| end | ||
|
|
||
| def language_from_confluence_class(node) | ||
| node['class'].to_s[/brush:\s?(:?.*);/, 1] | ||
| node["class"].to_s[/brush:\s?(:?.*);/, 1] |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data High
| stem = node.to_s.gsub(/\n/, " ") | ||
| stem = MathML2AsciiMath.m2a(stem) if ReverseAdoc.config.mathml2asciimath | ||
| stem = stem.gsub(/\[/, "\\[").gsub(/\]/, "\\]").gsub(/\(\(([^\)]+)\)\)/, "(\\1)") unless stem.nil? | ||
| unless stem.nil? | ||
| stem = stem.gsub(/\[/, "\\[").gsub(/\]/, "\\]").gsub( |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding High
| stem = node.to_s.gsub(/\n/, " ") | ||
| stem = MathML2AsciiMath.m2a(stem) if ReverseAdoc.config.mathml2asciimath | ||
| stem = stem.gsub(/\[/, "\\[").gsub(/\]/, "\\]").gsub(/\(\(([^\)]+)\)\)/, "(\\1)") unless stem.nil? | ||
| unless stem.nil? | ||
| stem = stem.gsub(/\[/, "\\[").gsub(/\]/, "\\]").gsub( |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding High
|
@xyz65535 for additional issues please help use a new PR. Thanks. |
From @xyz65535