Explicitly disable plugin when MIRRORD_ACTIVE=0 (#298)

* explicitly disable plugin when `MIRRORD_ACTIVE=0` * add changelog
metalbear-co · Nov 20, 2024 · b09b78d · b09b78d
1 parent 49ec3ba
commit b09b78d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/changelog.d/+explicitly-disable-from-env.added.md b/changelog.d/+explicitly-disable-from-env.added.md
@@ -0,0 +1 @@
+Setting `MIRRORD_ACTIVE=0` environment variable will explicitly disable mirrord.
diff --git a/modules/core/src/main/kotlin/com/metalbear/mirrord/MirrordExecManager.kt b/modules/core/src/main/kotlin/com/metalbear/mirrord/MirrordExecManager.kt
@@ -99,8 +99,10 @@ class MirrordExecManager(private val service: MirrordProjectService) {
         projectEnvVars: Map<String, String>?
     ): MirrordExecution? {
         MirrordLogger.logger.debug("MirrordExecManager.start")
-        val explicitlyEnabled = projectEnvVars?.any { (key, value) -> key == "MIRRORD_ACTIVE" && value == "1" } ?: false
-        if (!service.enabled && !explicitlyEnabled) {
+        val mirrordActiveValue = projectEnvVars?.get("MIRRORD_ACTIVE")
+        val explicitlyEnabled = mirrordActiveValue == "1"
+        val explicitlyDisabled = mirrordActiveValue == "0"
+        if ((!service.enabled && !explicitlyEnabled) || explicitlyDisabled) {
             MirrordLogger.logger.debug("disabled, returning")
             return null
         }
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Setting `MIRRORD_ACTIVE=0` environment variable will explicitly disable mirrord.